Skip to content

Commit

Permalink
Rename "current" to "not withdrawn"
Browse files Browse the repository at this point in the history
For: https://trello.com/c/KXyHx427/212-rename-current-to-not-withdrawn-when-sending-data-to-ga-on-publication-status
This is aimed at clearing up some confusion in GA data where documents that are marked as current/withdrawn may actually be in a third state where they are not relevant anymore but have not yet been withdrawn.
For this purpose, we're renaming the word "current" to "not withdrawn" to keep the current binary classification and reduce confusion.
  • Loading branch information
elenatanasoiu committed Aug 11, 2017
1 parent 644d302 commit f499cae
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion app/assets/javascripts/analytics/custom-dimensions.js
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
'political-status': {dimension: 7},
'analytics:organisations': {dimension: 9},
'analytics:world-locations': {dimension: 10},
'withdrawn': {dimension: 12, defaultValue: 'current'},
'withdrawn': {dimension: 12, defaultValue: 'not withdrawn'},
'schema-name': {dimension: 17},
'rendering-application': {dimension: 20},
'navigation-page-type': {dimension: 32, defaultValue: 'none'},
Expand Down
2 changes: 1 addition & 1 deletion spec/javascripts/analytics/ecommerce.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ describe('Ecommerce reporter for results pages', function() {
dimension11: '1',
dimension3: 'other',
dimension4: '00000000-0000-0000-0000-000000000000',
dimension12: 'current',
dimension12: 'not withdrawn',
dimension23: 'unknown',
dimension26: '0',
dimension27: '0',
Expand Down

0 comments on commit f499cae

Please sign in to comment.