Merge pull request #1286 from alphagov/js-spec-improvements

Improvements and tidy ups to the JS specs
alphagov · Feb 8, 2018 · 0617b42 · 0617b42
2 parents 8ea4b0f + 68d9921
commit 0617b42
Show file tree

Hide file tree

Showing 2 changed files with 348 additions and 299 deletions.
diff --git a/app/assets/javascripts/analytics/custom-dimensions.js b/app/assets/javascripts/analytics/custom-dimensions.js
@@ -82,15 +82,14 @@
       }
     });
 
-    customDimensions['dimension23'] = $('main[id="content"]').attr('lang') || 'unknown';
-
     return customDimensions;
   }
 
   function customDimensionsFromDom() {
     return {
       dimension26: GOVUK.PageContent.getNumberOfSections(),
-      dimension27: GOVUK.PageContent.getNumberOfLinks()
+      dimension27: GOVUK.PageContent.getNumberOfLinks(),
+      dimension23: $('main[id="content"]').attr('lang') || 'unknown'
     };
   }