-
Notifications
You must be signed in to change notification settings - Fork 9
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Clarify what getPageViewObject() is doing
There's a bunch of magic numbers and assumptions in this method about how many ga() functions have been called, in what order, and for what reason. This is fine, but it's hard to work out so we leave some more explicit comments, and introduce an expectation that will fail if our assumptions are false.
- Loading branch information
Showing
1 changed file
with
21 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters