Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add govuk web banners gem #6966

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ gem "gds-api-adapters"
gem "govspeak"
gem "govuk_app_config"
gem "govuk_publishing_components"
gem "govuk_web_banners"
gem "htmlentities"
gem "httparty"
gem "json"
Expand Down
4 changes: 4 additions & 0 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -205,6 +205,9 @@ GEM
capybara (>= 3.36)
puma
selenium-webdriver (>= 4.0)
govuk_web_banners (0.1.0)
govuk_publishing_components
rails (>= 7)
hashdiff (1.1.1)
htmlentities (4.3.4)
http-accept (1.7.0)
Expand Down Expand Up @@ -694,6 +697,7 @@ DEPENDENCIES
govuk_publishing_components
govuk_schemas
govuk_test
govuk_web_banners
htmlentities
httparty
json
Expand Down
3 changes: 2 additions & 1 deletion app/assets/javascripts/application.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,9 @@
//= require govuk_publishing_components/components/checkboxes
//= require govuk_publishing_components/components/error-summary
//= require govuk_publishing_components/components/govspeak
//= require govuk_publishing_components/components/intervention
//= require govuk_publishing_components/components/print-link
//= require govuk_publishing_components/components/radio
//= require govuk_publishing_components/components/step-by-step-nav
//= require govuk_publishing_components/components/table

//= require govuk_web_banners/dependencies
27 changes: 0 additions & 27 deletions app/helpers/recruitment_banner_helper.rb

This file was deleted.

1 change: 1 addition & 0 deletions app/views/layouts/application.html.erb
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
<% content_for :body do %>
<div class="smart_answer">
<%= yield :breadcrumbs %>
<%= render "govuk_web_banners/recruitment_banner" %>
<main id="content" role="main">
<%= yield %>
</main>
Expand Down
10 changes: 0 additions & 10 deletions app/views/shared/_intervention_banner.html.erb

This file was deleted.

11 changes: 0 additions & 11 deletions lib/data/recruitment_banners.yml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the test fixtures need to be removed as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh good spot. Thanks!

This file was deleted.

14 changes: 0 additions & 14 deletions test/fixtures/recruitment_banners.yml

This file was deleted.

51 changes: 0 additions & 51 deletions test/unit/helpers/recruitment_banner_helper_test.rb

This file was deleted.