Add govuk web banners gem #6966
Open
+8
−114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KludgeKML
force-pushed
the
add-govuk_web_banners-gem
branch
from
c9f13fe
to
bf5b737
Compare
leenagupte
reviewed
Nov 29, 2024
There was a problem hiding this comment.
I think the test fixtures need to be removed as well.
There was a problem hiding this comment.
Oh good spot. Thanks!
- add recruitment banners tag between breadcrumbs and main element
KludgeKML
force-pushed
the
add-govuk_web_banners-gem
branch
from
bf5b737
to
6055837
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove internal banner handling code/config for recruitment banners and replace with govuk_web_banners
https://trello.com/c/aYXKcrCo/375-create-govukwebbanner-gem-with-support-for-recruitment-banners
Follow these steps if you are doing a Rails upgrade.