-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Denmark marriage tool update - Content change request #2653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In preparation to extract a new Outcome for Denmark (opposite and same sex) duplicates target outcome by: `cp lib/smart_answer_flows/marriage-abroad/outcomes/outcome_opposite_sex_marriage_in_consular_cni_countries_when_residing_in_uk_or_ceremony_country.govspeak.erb lib/smart_answer_flows/marriage-abroad/outcomes/outcome_ceremonies_in_denmark_when_residing_in_uk_or_denmark.govspeak.erb` There is a discussion explaining why it is extracted and not added to the current outcome in [Trello][1]. See comment from @chrisroos [1]: https://trello.com/c/9mdERL9m/125-denmark-marriage-tool-update-content-change-request
The flow is updated to display the outcome: `outcome_ceremonies_in_denmark_when_residing_in_uk_or_denmark` for opposite sex ceremonies in Denmark only when the user is resident of UK.
Removes Denmark dependent code for UK residents from the outcome: `outcome_opposite_sex_marriage_in_consular_cni_countries_when_residing_in_uk_or_ceremony_country.govspeak.erb.` Under the new circumstances the outcome will never be reached.
Removes non-Denmark dependent code, as the outcome: `outcome_ceremonies_in_denmark_when_residing_in_uk_or_denmark.govspeak.` is specific to Denmark.
Update `outcome_ceremonies_in_denmark_when_residing_in_uk_or_denmark` for opposite-sex and Living in UK. Update the outcome according to the requirements described in [document][1]: [1]: https://trello.com/c/9mdERL9m/125-denmark-marriage-tool-update-content-change-request
The flow is updated to display the outcome: `outcome_ceremonies_in_denmark_when_residing_in_uk_or_denmark` for same sex ceremonies in Denmark only when the user is UK resident.
Update `outcome_ceremonies_in_denmark_when_residing_in_uk_or_denmark` for same_sex and Living in UK. Update the outcome according to the requirements described in [document][1]: [1]: https://trello.com/c/9mdERL9m/125-denmark-marriage-tool-update-content-change-request
The flow is updated to display the outcome: `outcome_ceremonies_in_denmark_when_residing_in_uk_or_denmark` for opposite sex ceremonies in Denmark when the user is resident in Denmark
The flow is updated to display the outcome: `outcome_ceremonies_in_denmark` for opposite sex ceremonies in Denmark when the user is resident in Denmark
The callout "Your partner will need to follow the same process and pay the fees to get their own CNI." should be placed below the informational paragraph starting "The names on all documents you provide must appear exactly as ..." to below the new "No trace letters" section.
Removes Denmark dependent code from `outcome_opposite_sex_marriage_in_consular_cni_countries_when_residing_in_uk_or_ceremony_country.govspeak.erb` because ceremonies in Denmark never reach that outcome.
pmanrubia
force-pushed
the
marriage-abroad-denmark-supersed-2576
branch
from
July 21, 2016 15:32
1f052e6
to
8d8272e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #2576
Trello card
Description
This story is linked to this Zendesk ticket.
Updates outcomes copy where a citizen lives in Uk or in Denmark according to this document.
Factcheck
denmark-marriage-tool-update-content-change-request
Expected changes (1)
Before
### After
## Expected changes (2) - [URL on GOV.UK](https://gov.uk/marriage-abroad/y/denmark/denmark/partner_local/same_sex) ### Before
### After