-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change from Beta Header to new Beta Notice #64
Conversation
In order to display to the user that the current page is in Beta, we can now include an element with an id attribute of beta-notice, which Slimmer will replace with the template in Static
Beta label only appears here as it was decided that the index page didn't need to be listed as a beta. Needs alphagov/slimmer#64 and alphagov/static#381 to be displayed.
Can you add a test for this? |
After some discussion with @evilstreak, we thought it might be a better idea to add this new style of beta label as an additional Beta indicator, instead of replacing the original Header style. This would give us the benefit of a few things:
If we were to go this route, we could stagger the change from the Header to the Label as each App is being worked on in future and drop the Header when we're sure it's not being used in any App. @amywhitney and @bradleywright - Thoughts? |
I'm not sure I understand the difference. Are you proposing to use a different Slimmer header to show an alternate beta label so we can phase the other one out gradually? |
Correct. When I said Header, I was talking about the Header design of showing that the page is in beta. |
I'm not clear on what the benefit of doing it that way is. The whole idea of using a shared frontend service is that all things get to share common messaging and styles. I'll come talk to you in person. |
A new Inserter Class for adding the Beta Label style. This will eventually replace the Beta Notice as the de-facto way to show Users that a page or service is in Beta. To use this, send a selector with a position like so: [Slimmer::Headers::BETA_LABEL] = "before:main.content" We currently only accept before and after as the 2 options for where it can be inserted. This follows on from #64 and alphagov/static#381.
Following on from alphagov/slimmer#64, it was decided to add the Beta Label and slowly phase out Beta Notice.
Marking as closed. Branch is OK to be deleted. |
For future reference — if you want to delete a branch of your own that is no longer needed you can just go ahead and delete it. |
A new Inserter Class for adding the Beta Label style. This will eventually replace the Beta Notice as the de-facto way to show Users that a page or service is in Beta. To use this, send a selector with a position like so: [Slimmer::Headers::BETA_LABEL] = "before:main.content" We currently only accept before and after as the 2 options for where it can be inserted. This follows on from #64 and alphagov/static#381.
A new Inserter Class for adding the Beta Label style. This will eventually replace the Beta Notice as the de-facto way to show Users that a page or service is in Beta. To use this, send a selector with a position like so: [Slimmer::Headers::BETA_LABEL] = "before:main.content" We currently only accept before and after as the 2 options for where it can be inserted. This follows on from #64 and alphagov/static#381.
In order to display to the user that the current page is in Beta, we can now include an element with an id attribute of beta-notice, which Slimmer will replace with the template in Static. Counterpart to a alphagov/static#381.