Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change from Beta Header to new Beta Notice #64

Closed
wants to merge 1 commit into from
Closed

Conversation

tommyp
Copy link
Contributor

@tommyp tommyp commented Mar 10, 2014

In order to display to the user that the current page is in Beta, we can now include an element with an id attribute of beta-notice, which Slimmer will replace with the template in Static. Counterpart to a alphagov/static#381.

In order to display to the user that the current page is in Beta,
we can now include an element with an id attribute of beta-notice, which
Slimmer will replace with the template in Static
tommyp added a commit to alphagov/contacts-admin that referenced this pull request Mar 10, 2014
Beta label only appears here as it was decided that the index page didn't
need to be listed as a beta.

Needs alphagov/slimmer#64 and
alphagov/static#381 to be displayed.
@evilstreak
Copy link
Contributor

Can you add a test for this?

@tommyp
Copy link
Contributor Author

tommyp commented Mar 12, 2014

After some discussion with @evilstreak, we thought it might be a better idea to add this new style of beta label as an additional Beta indicator, instead of replacing the original Header style. This would give us the benefit of a few things:

  1. Not having to hunt down where the Header style is being used and submit PRs for them all.
  2. Not having to figure out where the new style Beta Label will go.
  3. Not having to schedule deploys for these all at the same time.

If we were to go this route, we could stagger the change from the Header to the Label as each App is being worked on in future and drop the Header when we're sure it's not being used in any App.

@amywhitney and @bradleywright - Thoughts?

@bradwright
Copy link
Contributor

I'm not sure I understand the difference.

Are you proposing to use a different Slimmer header to show an alternate beta label so we can phase the other one out gradually?

@tommyp
Copy link
Contributor Author

tommyp commented Mar 12, 2014

Correct. When I said Header, I was talking about the Header design of showing that the page is in beta.
But that would introduce another Slimmer::Headers in order to do this.

@bradwright
Copy link
Contributor

I'm not clear on what the benefit of doing it that way is. The whole idea of using a shared frontend service is that all things get to share common messaging and styles.

I'll come talk to you in person.

tommyp added a commit that referenced this pull request Mar 12, 2014
A new Inserter Class for adding the Beta Label style. This will eventually
replace the Beta Notice as the de-facto way to show Users that a page or
service is in Beta.

To use this, send a selector with a position like so:
[Slimmer::Headers::BETA_LABEL] = "before:main.content"

We currently only accept before and after as the 2 options for where it
can be inserted.

This follows on from #64 and
alphagov/static#381.
tommyp added a commit to alphagov/static that referenced this pull request Mar 12, 2014
Following on from alphagov/slimmer#64, it was
decided to add the Beta Label and slowly phase out Beta Notice.
@tommyp
Copy link
Contributor Author

tommyp commented Mar 12, 2014

Marking as closed. Branch is OK to be deleted.

@tommyp tommyp closed this Mar 12, 2014
@evilstreak
Copy link
Contributor

For future reference — if you want to delete a branch of your own that is no longer needed you can just go ahead and delete it.

@evilstreak evilstreak deleted the beta-notice branch March 12, 2014 19:22
tommyp added a commit that referenced this pull request Mar 17, 2014
A new Inserter Class for adding the Beta Label style. This will eventually
replace the Beta Notice as the de-facto way to show Users that a page or
service is in Beta.

To use this, send a selector with a position like so:
[Slimmer::Headers::BETA_LABEL] = "before:main.content"

We currently only accept before and after as the 2 options for where it
can be inserted.

This follows on from #64 and
alphagov/static#381.
tommyp added a commit that referenced this pull request Mar 17, 2014
A new Inserter Class for adding the Beta Label style. This will eventually
replace the Beta Notice as the de-facto way to show Users that a page or
service is in Beta.

To use this, send a selector with a position like so:
[Slimmer::Headers::BETA_LABEL] = "before:main.content"

We currently only accept before and after as the 2 options for where it
can be inserted.

This follows on from #64 and
alphagov/static#381.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants