Update to govuk-frontend 3.7.0 #75
Conversation
alex-ju
force-pushed
the
update-to-govuk-frontend-3-7
branch
from
1be18f3
to
db5cb51
Compare
| background: transparent; | ||
| text-decoration: underline; |
There was a problem hiding this comment.
Could you add some explanation for these changes?
There was a problem hiding this comment.
Sure, I've now added a description to this commit:
Updating to govuk-frontend requires updating the govuk-back-link class we apply to our button element in a similar way govuk-frontend applies it to an anchor element. More on this change on the original PR in govuk-frontend alphagov/govuk-frontend#1753 – more specifically https://github.com/alphagov/govuk-frontend/pull/1753/files#diff-4c6ef8a7bcb3d85bc2f7e7a0cd1fd50cR33
| @@ -293,6 +293,12 @@ | |||
| .govuk-list--number > li { | |||
| margin-bottom: 5px; } } | |||
|
|
|||
| .govuk-list--spaced > li { | |||
There was a problem hiding this comment.
Could you add the command used here? (Or perhaps it should go in the README.)
There was a problem hiding this comment.
By running npm run build which is also triggered before the test suite is run.
Updating to govuk-frontend requires updating the govuk-back-link class we apply to our button element in a similar way govuk-frontend applies it to an anchor element. More on this change on the original PR in govuk-frontend alphagov/govuk-frontend#1753.
By running `npm run build`
alex-ju
force-pushed
the
update-to-govuk-frontend-3-7
branch
from
db5cb51
to
4c6e533
Compare
|
Thanks for the updated commits @alex-ju. I can see that the style changes do reflect the upstream ones. What's now puzzling me - and what I should have asked in my first review (sorry) - is: what is the back link for? I can see it gets put in here, but isn't displayed. So I'm wondering why we care about how it looks, if we can't see it 😆. |
Great question. The back link is used on mobile to allow upstream navigation across the taxonomy tree. |
|
Aha! Would have been helpful to have a before/after, but I've also learnt something, so no worries. Now I can see it, are we going to fix the weird half chevron while we're here?
|
I'm a bit confused by your comment 😕 there is a before and after in the pull request description and the whole point of this PR is to fix the chevron. |
## 1.3.2 - Fix back-link styles by updating miller-columns-element to `govuk-frontend` 3.7 (PR #75)
This change is intended to be a temporary fix for a style leakage issue, caused by unsynchronized dependency on
govuk-frontend(miller-columns-elementin 3.6.0 andcontent-publisherin 3.7.0), by updating this repo to the latest version.A proper fix should follow this PR by either scoping the
govuk-frontendcomponent styles (checkboxes, back-link, breadcrumbs) used in this repo or by making themiller-columns-elementnon-dependent on other components, leaving the required styles to only be imported in the project using it (e.g.content-publisher).Back link in Content Publisher