-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make back link arrow consistent with breadcrumb component #1753
Make back link arrow consistent with breadcrumb component #1753
Conversation
For reference, this change has been requested before via our backlog. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just noticed a small inconsistency with the breadcrumb chevron colour. Maybe that's deliberate but can't think of a reason they should be different. Otherwise all looks good 👍
5b85cb4
to
0daa3ef
Compare
0daa3ef
to
cfe88a6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked out locally, looks great to me 👍thanks!
Something slightly strange going on with the changelog – seeing duplicated entries for two unrelated changes. @vanitabarrett are you able to take a look? |
Oops, probably a rebase issue. I'll look into it |
cfe88a6
to
f95b4c8
Compare
@36degrees Fixed 👍 |
Thanks, @vanitabarrett 👏 |
This code is now available in govuk-frontend alphagov/govuk-frontend#1753
Updating to govuk-frontend requires updating the govuk-back-link class we apply to our button element in a similar way govuk-frontend applies it to an anchor element. More on this change on the original PR in govuk-frontend alphagov/govuk-frontend#1753.
What
This PR contains a few small changes to the back link component:
Note: this change has been implemented on GOVUK and we wish to contribute this change back to the design system.
Why
Before
After