Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make back link arrow consistent with breadcrumb component #1753

Merged
merged 4 commits into from
Apr 27, 2020

Conversation

vanitabarrett
Copy link
Contributor

What

This PR contains a few small changes to the back link component:

  • updates the back link arrow to be consistent with the breadcrumbs component
  • increase the touch target of the back link

Note: this change has been implemented on GOVUK and we wish to contribute this change back to the design system.

Why

  • Back links use an inconsistent icon from the breadcrumbs and there should be consistent design patterns across GOV.UK.
  • The touch target of the back link should be a minimum of 44x44px as recommended by WCAG guidelines
  • The touch target has been implemented regardless of device to handle people interacting with the link, for example, on touchscreen laptops.

Before

Screenshot 2020-03-02 at 13 57 42

Screenshot 2020-03-02 at 13 57 54

After

Screenshot 2020-03-02 at 13 58 02

Screenshot 2020-03-02 at 13 58 08

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-1753 March 2, 2020 14:12 Inactive
@timpaul
Copy link
Contributor

timpaul commented Mar 4, 2020

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-1753 April 21, 2020 09:11 Inactive
Copy link
Member

@christopherthomasdesign christopherthomasdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticed a small inconsistency with the breadcrumb chevron colour. Maybe that's deliberate but can't think of a reason they should be different. Otherwise all looks good 👍

src/govuk/components/back-link/_back-link.scss Outdated Show resolved Hide resolved
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-1753 April 27, 2020 14:21 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-1753 April 27, 2020 14:31 Inactive
Copy link
Member

@christopherthomasdesign christopherthomasdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked out locally, looks great to me 👍thanks!

@36degrees
Copy link
Contributor

Something slightly strange going on with the changelog – seeing duplicated entries for two unrelated changes. @vanitabarrett are you able to take a look?

@vanitabarrett
Copy link
Contributor Author

Oops, probably a rebase issue. I'll look into it

@vanitabarrett
Copy link
Contributor Author

@36degrees Fixed 👍

@36degrees 36degrees merged commit 4274238 into alphagov:master Apr 27, 2020
@36degrees
Copy link
Contributor

Thanks, @vanitabarrett 👏

@36degrees 36degrees mentioned this pull request May 19, 2020
7 tasks
@hannalaakso hannalaakso added this to the Next milestone May 19, 2020
@36degrees 36degrees mentioned this pull request Jun 1, 2020
alex-ju added a commit to alphagov/govuk_publishing_components that referenced this pull request Jun 2, 2020
This code is now available in govuk-frontend alphagov/govuk-frontend#1753
alex-ju added a commit to alphagov/miller-columns-element that referenced this pull request Jun 30, 2020
Updating to govuk-frontend requires updating the govuk-back-link class we apply to our button element in a similar way govuk-frontend applies it to an anchor element. More on this change on the original PR in govuk-frontend alphagov/govuk-frontend#1753.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

6 participants