Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add search-with-autocomplete to stylesheets served by static #4495

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

kevindew
Copy link
Member

@kevindew kevindew commented Dec 11, 2024

What

This adds the search-with-autocomplete component to the list of those served by static.

Why

We are adding this to static in: alphagov/static#3532 and want to avoid serving this stylesheet unnecessarily to users.

Visual Changes

None

@govuk-ci govuk-ci temporarily deployed to components-gem-pr-4495 December 11, 2024 14:49 Inactive
@kevindew kevindew force-pushed the add-search-autocomplete-to-static-components branch from df0871a to 779f7cb Compare December 11, 2024 14:50
This adds the search-with-autocomplete component stylesheet to the list of
those served by static. We are adding this to static in:
alphagov/static#3532 and want to avoid serving
this stylesheet unnecessarily to users.
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-4495 December 11, 2024 14:50 Inactive
@kevindew kevindew force-pushed the add-search-autocomplete-to-static-components branch from 779f7cb to 890cd99 Compare December 11, 2024 14:51
@kevindew kevindew changed the title Add search-with-autocomplete to assets served by static Add search-with-autocomplete to stylesheets served by static Dec 11, 2024
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-4495 December 11, 2024 14:51 Inactive
@kevindew kevindew merged commit 85e4334 into main Dec 11, 2024
12 checks passed
@kevindew kevindew deleted the add-search-autocomplete-to-static-components branch December 11, 2024 15:11
unoduetre added a commit that referenced this pull request Dec 11, 2024
* Add search-with-autocomplete to stylesheets served by static ([PR #4495](#4495))
* Add /media/ path to GA4 download link tracking ([PR #4491](#4491))
* Translate "and" connective in metadata component for some languages ([PR #4477](#4477))
@unoduetre unoduetre mentioned this pull request Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants