Translate "and" connective in metadata component for some languages #4477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unoduetre
commented
Dec 5, 2024
| @@ -20,6 +21,4 @@ | |||
| </a> | |||
| </div> | |||
| <span id="toggle-<%= toggle_id %>" class="gem-c-metadata__toggle-items js-hidden"><%= remaining.to_sentence.html_safe %></span> | |||
| <% else %> | |||
There was a problem hiding this comment.
This is a small refactoring I've done.
unoduetre
changed the title
unoduetre
force-pushed
the
3082-add-the-translation-for-and-in-the-metadata-component-for-french-and-spanish-m
branch
from
793f72a to
800ecda
Compare
unoduetre
force-pushed
the
3082-add-the-translation-for-and-in-the-metadata-component-for-french-and-spanish-m
branch
from
800ecda to
4267e37
Compare
unoduetre
force-pushed
the
3082-add-the-translation-for-and-in-the-metadata-component-for-french-and-spanish-m
branch
from
4267e37 to
1bec528
Compare
unoduetre
force-pushed
the
3082-add-the-translation-for-and-in-the-metadata-component-for-french-and-spanish-m
branch
from
1bec528 to
10aeaea
Compare
unoduetre
force-pushed
the
3082-add-the-translation-for-and-in-the-metadata-component-for-french-and-spanish-m
branch
from
10aeaea to
22daff1
Compare
unoduetre
force-pushed
the
3082-add-the-translation-for-and-in-the-metadata-component-for-french-and-spanish-m
branch
from
22daff1 to
1a1441b
Compare
MartinJJones
approved these changes
Dec 11, 2024
unoduetre
force-pushed
the
3082-add-the-translation-for-and-in-the-metadata-component-for-french-and-spanish-m
branch
from
1a1441b to
5ca6b40
Compare
unoduetre
deleted the
3082-add-the-translation-for-and-in-the-metadata-component-for-french-and-spanish-m
branch
unoduetre
added a commit
that referenced
this pull request
Dec 11, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fix the following issue:
The
Fromsection on documents is missing translations for the wordandsee https://www.gov.uk/government/publications/uk-candidate-for-the-international-court-of-justice-election-2026-professor-dapo-akande-election-brochure.frThe original ticket is about French and Spanish, as the authors are not sure which languages use "and" in the same way and which don't. I've extended the number of languages to the languages I know use "and" in the same way, namely Polish and German.
Why
Trello ticket
Visual Changes
Before
After