-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change breadcrumb class name #435
Conversation
bb92b91
to
cdcc184
Compare
- from 'gem-c-breadcrumbs--item' to 'gem-c-breadcrumbs__item' - was not following BEM convention, 'item' is an element, not a modifier
cdcc184
to
aa298ba
Compare
@@ -19,7 +19,7 @@ | |||
} | |||
|
|||
@include media-down(mobile) { | |||
&.gem-c-breadcrumbs--collapse-on-mobile .gem-c-breadcrumbs--item { | |||
&.gem-c-breadcrumbs--collapse-on-mobile .gem-c-breadcrumbs__item { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changing this class will mean all of these other repos will require a change aswell
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eeek. Thanks, good spot.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe a few apps - most of them look like prototypes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually looks like just collections. I'll raise a PR there to change it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DilwoarH have raised a PR in collections (alphagov/collections#796) - are you happy to approve this PR?
This should also fix the problem with this component in the 'highlight components' option of the GOV.UK browser extension, see below.
Component guide for this PR:
https://govuk-publishing-compon-pr-435.herokuapp.com/component-guide/