[DO NOT MERGE] Update test for breadcrumb component #796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tijmenb
reviewed
Jul 19, 2018
| @@ -504,13 +504,13 @@ class OrganisationTest < ActionDispatch::IntegrationTest | |||
|
|
|||
| it "displays breadcrumbs" do | |||
| visit "/government/organisations/prime-ministers-office-10-downing-street" | |||
| assert page.has_css?(".gem-c-breadcrumbs .gem-c-breadcrumbs--item", text: "Prime Minister's Office, 10 Downing Street") | |||
| assert page.has_css?(".gem-c-breadcrumbs .gem-c-breadcrumbs__item", text: "Prime Minister's Office, 10 Downing Street") | |||
There was a problem hiding this comment.
Maybe we can one-up this and remove the class name altogether, and test just test that the string appears in the gem-c-breadcrumbs element? That way we would have prevented this PR.
There was a problem hiding this comment.
Fair point, done.
- class used is about to change
andysellick
force-pushed
the
update-for-breadcrumb-component-change
branch
from
901c3e5 to
884295d
Compare
vanitabarrett
approved these changes
Jul 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates collections ahead of a change to the breadcrumb component in this PR.
Do not merge this PR until a new version of the components gem is created and added to this PR (until then tests will fail anyway).