Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent screen readers from announcing document list child/parts items dashes #4066

Merged
merged 1 commit into from
Jun 18, 2024
Merged

Prevent screen readers from announcing document list child/parts items dashes #4066

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@

## Unreleased

* Prevent screen readers from announcing document list child/parts items dashes ([PR #4066](https://github.com/alphagov/govuk_publishing_components/pull/4066))
* Align checkboxes component more toward Design System ([PR #4061](https://github.com/alphagov/govuk_publishing_components/pull/4061))
* Add govuk-frontend checking to the component auditing ([PR #4058](https://github.com/alphagov/govuk_publishing_components/pull/4058))

Expand Down
5 changes: 4 additions & 1 deletion app/assets/stylesheets/govuk_publishing_components/components/_document-list.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,10 +131,13 @@
padding-top: govuk-spacing(2);

&::before {
content: "—";
content: "";
position: absolute;
left: 0;
width: govuk-spacing(3);
overflow: hidden;
border-top: solid 1px $govuk-text-colour;
transform: translate(0, 0.5em);
}

@include govuk-media-query($from: desktop) {
Expand Down
1 change: 1 addition & 0 deletions app/views/govuk_publishing_components/components/docs/document_list.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ accessibility_criteria: |
The component must:

* inform the user how many items are in the list
* ensure dashes before each list item are hidden from screen readers
shared_accessibility_criteria:
- link
uses_component_wrapper_helper: true
Expand Down