Prevent screen readers from announcing document list child/parts items dashes #4066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andysellick
force-pushed
the
fix-document-list-list
branch
from
163225d to
19a5f8d
Compare
- prevent screen readers from announcing the dash before document list child/part items, by changing the CSS pseudo element to use a border to show the dash, instead of a dash character
andysellick
force-pushed
the
fix-document-list-list
branch
from
19a5f8d to
e931078
Compare
MartinJJones
approved these changes
Jun 18, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Prevent screen readers from announcing the dash before document list child/part items, by changing the CSS pseudo element to use a border to show the dash, instead of a dash character.
Why
Screen readers were announcing the dash character ("em-dash") which is unnecessary and distracting.
Visual Changes
The new border is slightly crisper than the dash character and fractionally narrower and higher than the dash character, but I don't believe the differences are a problem.
I've used a specific width for the element relative to the padding left of the list element, so that when the text size increases the dash remains the same size (otherwise it could overlap the text of the item, as the padding is fixed). Here's a screenshot of it with an increased text size.
Trello card: https://trello.com/c/yhLOWoMp/876-dashes-before-each-document-list-item-in-mobile-tablet-view-read-by-screen-readers-m