-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GA4 tracking to the document list component #3874
Conversation
7d82bc0
to
cb033c2
Compare
cb033c2
to
268ce22
Compare
268ce22
to
53423ed
Compare
Quick question - would we want to update the With data attributes on links section in the documentation for this component? Currently it says "Note that the component does not include built in tracking. If this is required consider using the track click script" If ga4 tracking is now enabled by default, would it be worth clarifying that the above is referring to UA? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good (just got a small change request) 👍
Thanks @JamesCGDS - should be ready for another review. I've updated that sentence in the docs as well to mention universal analytics. |
app/views/govuk_publishing_components/components/_document_list.html.erb
Outdated
Show resolved
Hide resolved
app/views/govuk_publishing_components/components/_document_list.html.erb
Outdated
Show resolved
Hide resolved
app/views/govuk_publishing_components/components/_document_list.html.erb
Show resolved
Hide resolved
f7adce0
to
5f67a98
Compare
Thanks @andysellick - should be ready for review again 👍 |
app/views/govuk_publishing_components/components/_document_list.html.erb
Outdated
Show resolved
Hide resolved
@AshGDS the visual diff test is mostly failing because of recently merged changes to the crown logo - if you rebase they should disappear. |
7ac5329
to
c2fa750
Compare
Thanks @andysellick - should be ready to review again. The visual failures seem to be because I added two new examples to the document list docs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏
c2fa750
to
32e764c
Compare
32e764c
to
e27bc41
Compare
What
ga4_data
object when rendering the component, similar to Expand GA4 share link tracking to allow for extra values #3872disable_ga4
to turn it off if needed. We do this instead of enabling tracking ourselves by passingga4_tracking: true
like we used to.Why
Visual Changes
Changed the document list examples to reflect the new tracking