Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand GA4 share link tracking to allow for extra values #3872

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

AshGDS
Copy link
Contributor

@AshGDS AshGDS commented Feb 12, 2024

What

  • Adds a variable called ga4_data to the share links component.
  • This variable allows an object to be passed through to the component with extra GA4 values.

Why

Visual Changes

The component example was updated to reflect the changes

@govuk-ci govuk-ci temporarily deployed to components-gem-pr-3872 February 12, 2024 14:20 Inactive
@AshGDS AshGDS changed the title Allow share links GA4 tracking to accept extra values passed through Expand GA4 share link tracking to allow for extra values Feb 12, 2024
@AshGDS AshGDS force-pushed the ga4-expand-share-link-tracking branch from 8c73481 to 56b0695 Compare February 12, 2024 14:21
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-3872 February 12, 2024 14:21 Inactive
@AshGDS AshGDS requested a review from JamesCGDS February 12, 2024 14:26
Copy link
Contributor

@JamesCGDS JamesCGDS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@AshGDS AshGDS merged commit 4b18154 into main Feb 13, 2024
12 checks passed
@AshGDS AshGDS deleted the ga4-expand-share-link-tracking branch February 13, 2024 14:27
@MartinJJones MartinJJones mentioned this pull request Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants