Iterate branding model #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andysellick
force-pushed
the
iterate-branding
branch
from
f6fab5e to
89a8b6b
Compare
|
Looks good to me 👍 My only question... our branding classes aren't specific to the component that's calling it (i.e: the styling isn't applicable to only .gem-c-[component-name]). I'm not sure if this is a problem? I guess it's not as the brand styling is always the same... |
|
@vanitabarrett I'd originally planned to make it component specific but couldn't think of a way of doing it that didn't result in duplicating all of the branding styles for every component. This way it can be shared between more than one component without a hit to the size of the CSS. |
- rename get_brand method - have explicit methods for color and border-color instead of one with a parameter
- use new methods - add test
vanitabarrett
approved these changes
May 10, 2018
andysellick
force-pushed
the
iterate-branding
branch
from
89a8b6b to
32c3aac
Compare
andysellick
force-pushed
the
iterate-branding
branch
from
32c3aac to
ccbf81d
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the colour branding model following @tijmenb 's comments on the PR to add it.
Note that there are a few components that have started using this model already, I'll need to rebase and update these PRs once this change is approved.