Subscription links add colour and tracking #299
Conversation
| feed_link_data = false | ||
| feed_link_data_attributes ||= {} | ||
|
|
||
| tracking_is_present = true if email_signup_link_data_attributes || !feed_link_data_attributes.empty? |
There was a problem hiding this comment.
!feed_link_data_attributes.empty? is a bit confusing. How about feed_link_data_attributes.any? ?
There was a problem hiding this comment.
Thanks, that's much better.
| @@ -1,39 +1,45 @@ | |||
| <% | |||
| email_signup_link ||= false | |||
| email_signup_link_text ||= t("govuk_component.subscription_links.email_signup_link_text", default: "Get email alerts") | |||
| email_signup_link_data_attributes ||= false | |||
There was a problem hiding this comment.
This section at the top of the component is getting quite large now, and making it difficult to follow what's happening in the view. Can we move some of this logic out into a helper?
There was a problem hiding this comment.
Gave it a go but by the time I've passed everything I need out to the helper and back again I'm not sure it actually saves any lines of code.
There was a problem hiding this comment.
Can we do something like we do for the related navigation component and just pass through the local assigns?
<% related_nav_helper = GovukPublishingComponents::Presenters::RelatedNavigationHelper.new(local_assigns) %>
There was a problem hiding this comment.
@vanitabarrett ah good idea, I'd forgotten you can do that, thanks. Have moved the code into a helper.
|
Also possibly out of scope of this PR, but the component guide page for this component now errors because of a duplicate ID. It works when running on heroku etc, but stops you from viewing it locally. |
andysellick
force-pushed
the
subscription-links-add-colour-and-tracking
branch
from
b74ff83 to
a2a0684
Compare
|
@vanitabarrett have fixed the duplicate id problem, I'd spotted it but was being lazy :) |
andysellick
force-pushed
the
subscription-links-add-colour-and-tracking
branch
from
2d2e237 to
57b635f
Compare
andysellick
force-pushed
the
subscription-links-add-colour-and-tracking
branch
from
57b635f to
8f52856
Compare
andysellick
force-pushed
the
subscription-links-add-colour-and-tracking
branch
from
8f52856 to
7e2f1d4
Compare
andysellick
force-pushed
the
subscription-links-add-colour-and-tracking
branch
from
7e2f1d4 to
4fbaf8b
Compare
- expand feed link test to check for toggle module - improve template readability - test modules are not added unless needed - make test for data modules more specific - make id for feed box unique
andysellick
force-pushed
the
subscription-links-add-colour-and-tracking
branch
from
4fbaf8b to
f6fee99
Compare
Adds colour branding options and the ability to add tracking to the subscription links component.
Component guide: https://govuk-publishing-compon-pr-299.herokuapp.com/component-guide/subscription-links
Trello card: https://trello.com/c/NjgS3vym/55-modify-component-subscription-links