Fix header environment label layout on mobile #1212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently headers with envirobment label on mobile overlap the menu button if it exists. This is caused by `white-space: nowrap;` on the `.gem-c-header__logo`. This property doesn't exist in the GOV.UK Design system code and removing doesn't look to cause any issues. Fixes #1029
kr8n3r
force-pushed
the
hif-header-label-display
branch
from
1acdecb to
e0142a6
Compare
Merged
kr8n3r
added a commit
that referenced
this pull request
Nov 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes #1029
Why
Currently headers with environment label on mobile overlap the menu button if it exists.
This is caused by
white-space: nowrap;on the.gem-c-header__logo.This property doesn't exist in the GOV.UK Design system code and removing doesn't look to cause any issues.
Preview
Visual Changes
Before
After