-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix feedback component layout on mobile #1211
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kr8n3r
changed the title
WIP: Fix feedback component layout on mobile
Fix feedback component layout on mobile
Nov 28, 2019
kr8n3r
force-pushed
the
fix-feedback-component-layoput-on-mobile
branch
from
November 28, 2019 13:24
00d57d2
to
811d8e7
Compare
kr8n3r
force-pushed
the
fix-feedback-component-layoput-on-mobile
branch
from
November 29, 2019 10:16
811d8e7
to
28795f6
Compare
alex-ju
approved these changes
Nov 29, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Our very first second CSS grid usage 🎉 ! Looks good. Some inconsistencies with IEx on very narrow screens that, as you mentioned, could be addressed by wrapping the code with feature queries.
@andysellick uuu.. I missed that one. Nice work @andysellick! |
kr8n3r
force-pushed
the
fix-feedback-component-layoput-on-mobile
branch
from
November 29, 2019 11:39
28795f6
to
a0128d8
Compare
With #1207 we inadvertently broke the component's layout on mobile. This PR fixes the component layout on mobile by: - using CSS grid for the mobile viewport - moves link classes to list elements and introduces additional classes to use with the grid positioning
kr8n3r
force-pushed
the
fix-feedback-component-layoput-on-mobile
branch
from
November 29, 2019 11:42
a0128d8
to
fb3d986
Compare
kr8n3r
force-pushed
the
fix-feedback-component-layoput-on-mobile
branch
from
November 29, 2019 11:48
fb3d986
to
36b371e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fix Feedback component layout on mobile.
Why
With #1207 we inadvertently broke the component's layout on mobile.
Before #1207
See: https://www.gov.uk/guidance/style-guide/a-to-z-of-gov-uk-style
After #1207
See: https://www.gov.uk/change-name-deed-poll
After this change
https://govuk-publishing-compo-pr-1211.herokuapp.com/component-guide/feedback
Alternative options
Trello ticket