Remove accessible autocomplete component #1038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-ju
force-pushed
the
remove-accessible-autocomplete-component
branch
from
f120038 to
6380a49
Compare
andysellick
approved these changes
Aug 9, 2019
andysellick
added a commit
that referenced
this pull request
Nov 26, 2021
- this is the code for the previous version of the component, removed in #1038 - does not use the git branch or code for multiple selections, as this is not needed - otherwise unchanged and apparently functional, but some functionality here is not required and tests are failing
andysellick
added a commit
that referenced
this pull request
Nov 26, 2021
- this is the code for the previous version of the component, removed in #1038 - does not use the git branch or code for multiple selections, as this is not needed - otherwise unchanged and apparently functional, but some functionality here is not required and tests are failing
andysellick
added a commit
that referenced
this pull request
Nov 29, 2021
- this is the code for the previous version of the component, removed in #1038 - does not use the git branch or code for multiple selections, as this is not needed - otherwise unchanged and apparently functional, but some functionality here is not required and tests are failing
MuriloDalRi
added a commit
to alphagov/content-data-admin
that referenced
this pull request
Mar 29, 2023
This component was removed in version 18 of govuk_publishing_components alphagov/govuk_publishing_components#1038 We need to move the code into the app so that we can update govuk_publishing_components and other dependencies. https://trello.com/c/egaF1kjo/3110-replace-accessible-autocomplete-for-content-data-admin
MuriloDalRi
added a commit
to alphagov/content-data-admin
that referenced
this pull request
Apr 3, 2023
This component was removed in version 18 of govuk_publishing_components alphagov/govuk_publishing_components#1038 We need to move the code into the app so that we can update govuk_publishing_components and other dependencies. https://trello.com/c/egaF1kjo/3110-replace-accessible-autocomplete-for-content-data-admin
MuriloDalRi
added a commit
to alphagov/content-data-admin
that referenced
this pull request
Apr 3, 2023
This component was removed in version 18 of govuk_publishing_components alphagov/govuk_publishing_components#1038 We need to move the code into the app so that we can update govuk_publishing_components and other dependencies. https://trello.com/c/egaF1kjo/3110-replace-accessible-autocomplete-for-content-data-admin
MuriloDalRi
added a commit
to alphagov/content-data-admin
that referenced
this pull request
Apr 3, 2023
This component was removed in version 18 of govuk_publishing_components alphagov/govuk_publishing_components#1038 We need to move the code into the app so that we can update govuk_publishing_components and other dependencies. https://trello.com/c/egaF1kjo/3110-replace-accessible-autocomplete-for-content-data-admin
MuriloDalRi
added a commit
to alphagov/content-data-admin
that referenced
this pull request
Apr 3, 2023
This component was removed in version 18 of govuk_publishing_components alphagov/govuk_publishing_components#1038 We need to move the code into the app so that we can update govuk_publishing_components and other dependencies. https://trello.com/c/egaF1kjo/3110-replace-accessible-autocomplete-for-content-data-admin
MuriloDalRi
added a commit
to alphagov/content-data-admin
that referenced
this pull request
Apr 3, 2023
This component was removed in version 18 of govuk_publishing_components alphagov/govuk_publishing_components#1038 We need to move the code into the app so that we can update govuk_publishing_components and other dependencies. https://trello.com/c/egaF1kjo/3110-replace-accessible-autocomplete-for-content-data-admin
robinjam
pushed a commit
to alphagov/content-data-admin
that referenced
this pull request
Apr 25, 2023
This component was removed in version 18 of govuk_publishing_components alphagov/govuk_publishing_components#1038 We need to move the code into the app so that we can update govuk_publishing_components and other dependencies. https://trello.com/c/egaF1kjo/3110-replace-accessible-autocomplete-for-content-data-admin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Remove the accessible-autocomplete component
Why
The accessible-autocomplete component was introduced in #621, was tested with users in finders-frontend and was replaced with an enhanced version of the option-select component.
The only application where this component is being used is content-data-admin, and we plan to move the component there.
The main reason for removing it:
Visual Changes
No visual changes
View Changes
https://govuk-publishing-compo-pr-1038.herokuapp.com/