Move code for accessible autocomplete component into app #1183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andysellick
force-pushed
the
accessible-autocomplete
branch
from
751b864 to
d14b007
Compare
MuriloDalRi
force-pushed
the
accessible-autocomplete
branch
8 times, most recently
from
b8b2f01 to
ca5b5f7
Compare
robinjam
force-pushed
the
accessible-autocomplete
branch
5 times, most recently
from
a2987e7 to
225932c
Compare
andysellick
reviewed
Apr 17, 2023
app/assets/stylesheets/components/_accessible-autocomplete.scss
Outdated
Show resolved
Hide resolved
robinjam
force-pushed
the
accessible-autocomplete
branch
from
5f9979d to
9a84ca0
Compare
This component was removed in version 18 of govuk_publishing_components alphagov/govuk_publishing_components#1038 We need to move the code into the app so that we can update govuk_publishing_components and other dependencies. https://trello.com/c/egaF1kjo/3110-replace-accessible-autocomplete-for-content-data-admin
This file is not needed now that we run CI in GitHub Actions. Jenkins CI also fails because it's on an old version of NodeJS that isn't supported by some dependencies.
Update media queries for mobile Replace missing $white Sass variable Replace missing $black Sass variable Replace missing $grey Sass variables Replace govuk-focusable-fill deprecated mixin Replace incorrect govuk-colour Sass references
This is now possible because we've update govuk_publishing_components
This defines what linker should be used for installing Node packages. For more information see https://yarnpkg.com/configuration/yarnrc#nodeLinker
➤ YN0000: ┌ Resolution step ➤ YN0000: └ Completed in 0s 385ms ➤ YN0000: ┌ Fetch step ➤ YN0013: │ jquery@npm:3.6.3 can't be found in the cache and will be fetched from the remote registry ➤ YN0000: └ Completed in 0s 806ms ➤ YN0000: ┌ Link step ➤ YN0000: └ Completed in 1s 992ms ➤ YN0000: Done in 3s 230ms The following files are also generated but are not included as per https://yarnpkg.com/getting-started/qa#which-files-should-be-gitignored: - .yarn/cache/ - .yarn/install-state.gz
Modules now require an `init` method defined on their prototype in order to be started: https://github.com/alphagov/govuk_publishing_components/blob/348777af067269c71da8783cc68aebdd4f8d6448/app/assets/javascripts/govuk_publishing_components/modules.js#L40
We no longer use jQuery (although `$()` appears to be an alias of `document.querySelector()` for some reason)
This code was never actually used in this app: The `track` function is only called if `data-track-category` and `data-track-action` are both set on the <select> element. These attributes would be set in `app/views/components/_accessible_autocomplete.html.erb` if a `data_attributes` local is passed in. I've had a look through all the views where we include this partial, and none of them pass any locals when rendering the partial. Given this, I'm going to remove the tracking code, which also allows us to remove the entire `onConfirm` function (as the remainder of the function is a workaround for a bug caused by the fact that we override `onConfirm`).
robinjam
force-pushed
the
accessible-autocomplete
branch
from
6601c4c to
105997a
Compare
Fixes an issue where the default/empty option has a different height from the other options, making it appear not to be selectable
robinjam
force-pushed
the
accessible-autocomplete
branch
from
105997a to
c2ccde6
Compare
andysellick
approved these changes
Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This component was removed in version 18 of govuk_publishing_components alphagov/govuk_publishing_components#1038
We need to move the code into the app so that we can update govuk_publishing_components and other dependencies.
https://trello.com/c/egaF1kjo/3110-replace-accessible-autocomplete-for-content-data-admin
Follow these steps if you are doing a Rails upgrade.