Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecation message #608

Merged
merged 1 commit into from
Jun 11, 2018
Merged

Add deprecation message #608

merged 1 commit into from
Jun 11, 2018

Conversation

kr8n3r
Copy link

@kr8n3r kr8n3r commented Jun 11, 2018

We're adding messaging to inform users that GOV.UK elements is being superseded by GOV.UK Design System.

Screenshots (if appropriate):

screen shot 2018-06-11 at 14 17 26

@stevenaproctor
Copy link

@igloosi Does it need to look like a validation error summary box?

@kr8n3r
Copy link
Author

kr8n3r commented Jun 11, 2018

@stevenaproctor following our internal design by Dave. is there a more appropriate design for this kind of message?

@stevenaproctor
Copy link

@igloosi I know red can alarm and stress some people. Especially when it is not linked to something they have just done. A blue outline because it is information may make more sense.

There was a long discussion of alerts at alphagov/govuk-design-system-backlog#2

@kr8n3r kr8n3r force-pushed the add-deprecation-message branch from 879902e to 8683f29 Compare June 11, 2018 13:18
@kr8n3r
Copy link
Author

kr8n3r commented Jun 11, 2018

updated design (see first comment)

Copy link
Contributor

@timpaul timpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work - thanks for doing it so quickly

@kr8n3r kr8n3r merged commit 04d1686 into master Jun 11, 2018
@kr8n3r kr8n3r deleted the add-deprecation-message branch June 11, 2018 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants