Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3.0.0 #420

Merged
merged 1 commit into from
Mar 16, 2017
Merged

v3.0.0 #420

merged 1 commit into from
Mar 16, 2017

Conversation

robinwhittleton
Copy link
Contributor

  • Breaking changes to form validation (#PR 405)

This adds two new classes: .form-group-error and .form-control-error, and removes the old .error class. This lets specific controls within a group be accurately marked as having errors. For example, this allows parts of a date entry to be marked rather than the whole section.

To upgrade, you’ll need to change any occurences of .error that were applied to form groups to be .form-group-error, and then add .form-control-error to the failing input inside.

  • Radio buttons and checkboxes have new markup that doesn’t need JavaScript (PR #406)

Previously the radio buttons and checkboxes relied on selection-buttons.js (from govuk_frontend_toolkit) to work. By reworking the markup (see examples) we’ve been able remove this requirement.

To upgrade, you’ll need to change your markup to match the new pattern. Once that has been done you’ll be able to stop including selection-buttons.js and remove the GOVUK.SelectionButtons constructor from your JavaScript. The look and feel remains the same barring some tweaks to the focus weight. Accessibility and device compatibility remains the same as the previous version.

  • Add examples of phase tags used outside of phase banners (PR #366)
  • Fix invisible input content when changing colours (PR #397)
  • Recommend the use of aria-current="page" for the last breadcrumb (PR #418)

- Breaking changes to form validation (#PR 405)

This adds two new classes: `.form-group-error` and `.form-control-error`, and removes the old `.error` class. This lets specific controls within a group be accurately marked as having errors. For example, this allows parts of a date entry to be marked rather than the whole section.

To upgrade, you’ll need to change any occurences of `.error` that were applied to form groups to be `.form-group-error`, and then add `.form-control-error` to the failing input inside.

- Radio buttons and checkboxes have new markup that doesn’t need JavaScript (PR #406)

Previously the radio buttons and checkboxes relied on selection-buttons.js (from govuk_frontend_toolkit) to work. By reworking the markup we’ve been able remove this requirement.

To upgrade, you’ll need to change your markup to match the new pattern. Once that has been done you’ll be able to stop including selection-buttons.js and remove the `GOVUK.SelectionButtons` constructor from your JavaScript. The look and feel remains the same barring some tweaks to the focus weight. Accessibility and device compatibility remains the same as the previous version.

- Add examples of phase tags used outside of phase banners (PR #366)
- Fix invisible input content when changing colours (PR #397)
- Recommend the use of `aria-current="page"` for the last breadcrumb (PR #418)
@gemmaleigh gemmaleigh merged commit 7b3b47d into master Mar 16, 2017
@gemmaleigh gemmaleigh deleted the version_bump branch April 7, 2017 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants