Add an aria-current attribute to the breadcrumbs #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the breadcrumb to be consistent with GOV.UK, and sets aria-current to page, as described here: http://tink.uk/using-the-aria-current-attribute/.
robinwhittleton
pushed a commit
that referenced
this pull request
Mar 16, 2017
- Breaking changes to form validation (#PR 405) This adds two new classes: `.form-group-error` and `.form-control-error`, and removes the old `.error` class. This lets specific controls within a group be accurately marked as having errors. For example, this allows parts of a date entry to be marked rather than the whole section. To upgrade, you’ll need to change any occurences of `.error` that were applied to form groups to be `.form-group-error`, and then add `.form-control-error` to the failing input inside. - Radio buttons and checkboxes have new markup that doesn’t need JavaScript (PR #406) Previously the radio buttons and checkboxes relied on selection-buttons.js (from govuk_frontend_toolkit) to work. By reworking the markup we’ve been able remove this requirement. To upgrade, you’ll need to change your markup to match the new pattern. Once that has been done you’ll be able to stop including selection-buttons.js and remove the `GOVUK.SelectionButtons` constructor from your JavaScript. The look and feel remains the same barring some tweaks to the focus weight. Accessibility and device compatibility remains the same as the previous version. - Add examples of phase tags used outside of phase banners (PR #366) - Fix invisible input content when changing colours (PR #397) - Recommend the use of `aria-current="page"` for the last breadcrumb (PR #418)
Merged
robinwhittleton
pushed a commit
that referenced
this pull request
Mar 16, 2017
- Breaking changes to form validation (#PR 405) This adds two new classes: `.form-group-error` and `.form-control-error`, and removes the old `.error` class. This lets specific controls within a group be accurately marked as having errors. For example, this allows parts of a date entry to be marked rather than the whole section. To upgrade, you’ll need to change any occurences of `.error` that were applied to form groups to be `.form-group-error`, and then add `.form-control-error` to the failing input inside. - Radio buttons and checkboxes have new markup that doesn’t need JavaScript (PR #406) Previously the radio buttons and checkboxes relied on selection-buttons.js (from govuk_frontend_toolkit) to work. By reworking the markup we’ve been able remove this requirement. To upgrade, you’ll need to change your markup to match the new pattern. Once that has been done you’ll be able to stop including selection-buttons.js and remove the `GOVUK.SelectionButtons` constructor from your JavaScript. The look and feel remains the same barring some tweaks to the focus weight. Accessibility and device compatibility remains the same as the previous version. - Add examples of phase tags used outside of phase banners (PR #366) - Fix invisible input content when changing colours (PR #397) - Recommend the use of `aria-current="page"` for the last breadcrumb (PR #418)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does the pull request solve?
This PR updates the breadcrumbs to use the aria-current attribute as described here:
http://tink.uk/using-the-aria-current-attribute/.
Fixes #412.
What type of change is it?
Has the documentation been updated?