Remove unused SidekiqQueueSizeCheck base class #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was once used by Email Alert API [1], but was then changed to a custom alert [2], which was then removed [3]. In general, we should avoid monitoring the size of a queue, since the fact we have work to do is not a problem - what matters is whether we can do it. [1]: alphagov/email-alert-api#48 [2]: alphagov/govuk-puppet#10064 [3]: alphagov/govuk-puppet#10534
benthorner
force-pushed
the
remove-queue-size-check
branch
from
e73e6c2 to
12d9778
Compare
1pretz1
approved these changes
Sep 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://trello.com/c/zrq6ih4v/528-investigate-removal-of-no-processes-found-for-x-for-apps-with-a-healthcheck
This was once used by Email Alert API 1, but was then changed to
a custom alert 2, which was then removed 3. In general, we should
avoid monitoring the size of a queue, since the fact we have work to
do is not a problem - what matters is whether we can do it.