Merge pull request #156 from alphagov/remove-queue-size-check

Remove unused SidekiqQueueSizeCheck base class
alphagov · Sep 14, 2020 · 2e17ceb · 2e17ceb
2 parents ecb8891 + 12d9778
commit 2e17ceb
Show file tree

Hide file tree

Showing 6 changed files with 5 additions and 58 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,7 @@
+# 2.3.0
+
+* Remove unused SidekiqQueueSizeCheck healthcheck base class
+
 # 2.2.2
 
 * Add www.googletagmanager.com and www.gstatic.com to Content Security Policy (https://github.com/alphagov/govuk_app_config/pull/153)

diff --git a/docs/healthchecks.md b/docs/healthchecks.md
@@ -128,24 +128,6 @@ class MySidekiqQueueLatencyCheck < GovukHealthcheck::SidekiqQueueLatencyCheck
 end
 ```
 
-### `SidekiqQueueSizeCheck`
-
-This class is the basis for a check which compares the Sidekiq queue sizes
-with warning or critical thresholds.
-
-```ruby
-class MySidekiqQueueSizeCheck < GovukHealthcheck::SidekiqQueueSizeCheck
-  def warning_threshold(queue:)
-    # the warning threshold for a particular queue
-  end
-
-  def critical_threshold(queue:)
-    # the critical threshold for a particular queue
-  end
-end
-```
-
-
 ### `SidekiqRetrySizeCheck`
 
 Similar to `SidekiqQueueSizeCheck`, this class is the basis for a check which

diff --git a/lib/govuk_app_config/govuk_healthcheck.rb b/lib/govuk_app_config/govuk_healthcheck.rb
@@ -4,7 +4,6 @@
 require "govuk_app_config/govuk_healthcheck/threshold_check"
 require "govuk_app_config/govuk_healthcheck/sidekiq_queue_check"
 require "govuk_app_config/govuk_healthcheck/sidekiq_queue_latency_check"
-require "govuk_app_config/govuk_healthcheck/sidekiq_queue_size_check"
 require "govuk_app_config/govuk_healthcheck/sidekiq_retry_size_check"
 require "json"
 

diff --git a/lib/govuk_app_config/govuk_healthcheck/sidekiq_queue_size_check.rb b/lib/govuk_app_config/govuk_healthcheck/sidekiq_queue_size_check.rb
diff --git a/lib/govuk_app_config/version.rb b/lib/govuk_app_config/version.rb
@@ -1,3 +1,3 @@
 module GovukAppConfig
-  VERSION = "2.2.2".freeze
+  VERSION = "2.3.0".freeze
 end
diff --git a/spec/lib/govuk_healthcheck/sidekiq_queue_size_check_spec.rb b/spec/lib/govuk_healthcheck/sidekiq_queue_size_check_spec.rb