This repository has been archived by the owner on Nov 10, 2023. It is now read-only.
Remove redundant config #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benthorner
reviewed
Jan 18, 2021
benthorner
approved these changes
Jan 18, 2021
ChrisBAshton
force-pushed
the
ChrisBAshton-patch-1
branch
from
6530cd1 to
2cdfa9b
Compare
The sassLint option was removed in alphagov/govuk-jenkinslib#80 And the Yarn install step is unnecessary as of alphagov/govuk-jenkinslib#82 The `yarn run lint` step should still [run after yarn dependencies have been installed](https://github.com/alphagov/govuk-jenkinslib/pull/82/files#diff-6f9c4dd7a8fcf2fc03dc9947f9c2253a3d3d640daf5d986943e4f1d1dfca306bR191). And the rubyLintDiff option was removed in alphagov/govuk-jenkinslib#57.
ChrisBAshton
force-pushed
the
ChrisBAshton-patch-1
branch
from
2cdfa9b to
aad04e7
Compare
|
We're archiving this repo, so I'll close this PR. Thanks anyway @ChrisBAshton |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sassLint option was removed in alphagov/govuk-jenkinslib#80
And the Yarn install step is unnecessary as of alphagov/govuk-jenkinslib#82
The
yarn run lintstep should still run after yarn dependencies have been installed.And the rubyLintDiff option was removed in alphagov/govuk-jenkinslib#57.
Search page examples to sanity check:
Other finders