This repository has been archived by the owner on Jan 30, 2024. It is now read-only.
Detect and install yarn dependencies automatically #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's common for GOV.UK Rails apps to have yarn dependencies, currently
many any apps have a hook of: `beforeTest: { sh("yarn install") },`. The
changes in this commit will mean this can be removed.
ChrisBAshton
approved these changes
Jan 18, 2021
ChrisBAshton
added a commit
to alphagov/email-alert-frontend
that referenced
this pull request
Jan 18, 2021
The sassLint option was removed in alphagov/govuk-jenkinslib#80 And the Yarn install step is unnecessary as of alphagov/govuk-jenkinslib#82
ChrisBAshton
added a commit
to alphagov/smart-answers
that referenced
this pull request
Jan 18, 2021
The sassLint option was removed in alphagov/govuk-jenkinslib#80 And the Yarn install step is unnecessary as of alphagov/govuk-jenkinslib#82
ChrisBAshton
added a commit
to alphagov/manuals-frontend
that referenced
this pull request
Jan 18, 2021
The sassLint option was removed in alphagov/govuk-jenkinslib#80 And the Yarn install step is unnecessary as of alphagov/govuk-jenkinslib#82
ChrisBAshton
added a commit
to alphagov/finder-frontend
that referenced
this pull request
Jan 18, 2021
The sassLint option was removed in alphagov/govuk-jenkinslib#80 And the Yarn install step is unnecessary as of alphagov/govuk-jenkinslib#82
ChrisBAshton
added a commit
to alphagov/collections-publisher
that referenced
this pull request
Jan 18, 2021
The sassLint option was removed in alphagov/govuk-jenkinslib#80 And the Yarn install step is unnecessary as of alphagov/govuk-jenkinslib#82
ChrisBAshton
added a commit
to alphagov/support
that referenced
this pull request
Jan 18, 2021
The sassLint option was removed in alphagov/govuk-jenkinslib#80 And the Yarn install step is unnecessary as of alphagov/govuk-jenkinslib#82
ChrisBAshton
added a commit
to alphagov/search-admin
that referenced
this pull request
Jan 18, 2021
The sassLint option was removed in alphagov/govuk-jenkinslib#80 And the Yarn install step is unnecessary as of alphagov/govuk-jenkinslib#82
ChrisBAshton
added a commit
to alphagov/content-tagger
that referenced
this pull request
Jan 18, 2021
The sassLint option was removed in alphagov/govuk-jenkinslib#80 And the Yarn install step is unnecessary as of alphagov/govuk-jenkinslib#82
ChrisBAshton
added a commit
to alphagov/collections
that referenced
this pull request
Jan 18, 2021
The sassLint option was removed in alphagov/govuk-jenkinslib#80 And the Yarn install step is unnecessary as of alphagov/govuk-jenkinslib#82
ChrisBAshton
added a commit
to alphagov/frontend
that referenced
this pull request
Jan 18, 2021
The sassLint option was removed in alphagov/govuk-jenkinslib#80 And the Yarn install step is unnecessary as of alphagov/govuk-jenkinslib#82
ChrisBAshton
added a commit
to alphagov/specialist-publisher
that referenced
this pull request
Jan 18, 2021
The sassLint option was removed in alphagov/govuk-jenkinslib#80 And the Yarn install step is unnecessary as of alphagov/govuk-jenkinslib#82
ChrisBAshton
added a commit
to alphagov/short-url-manager
that referenced
this pull request
Jan 18, 2021
The sassLint option was removed in alphagov/govuk-jenkinslib#80 And the Yarn install step is unnecessary as of alphagov/govuk-jenkinslib#82
ChrisBAshton
added a commit
to alphagov/short-url-manager
that referenced
this pull request
Jan 18, 2021
The sassLint option was removed in alphagov/govuk-jenkinslib#80 And the Yarn install step is unnecessary as of alphagov/govuk-jenkinslib#82
ChrisBAshton
added a commit
to alphagov/feedback
that referenced
this pull request
Jan 18, 2021
The sassLint option was removed in alphagov/govuk-jenkinslib#80 And the Yarn install step is unnecessary as of alphagov/govuk-jenkinslib#82
ChrisBAshton
added a commit
to alphagov/content-data-admin
that referenced
this pull request
Jan 18, 2021
The sassLint option was removed in alphagov/govuk-jenkinslib#80 And the Yarn install step is unnecessary as of alphagov/govuk-jenkinslib#82
ChrisBAshton
added a commit
to alphagov/signon
that referenced
this pull request
Jan 18, 2021
The sassLint option was removed in alphagov/govuk-jenkinslib#80 And the Yarn install step is unnecessary as of alphagov/govuk-jenkinslib#82
ChrisBAshton
added a commit
to alphagov/publisher
that referenced
this pull request
Jan 18, 2021
The sassLint option was removed in alphagov/govuk-jenkinslib#80 And the Yarn install step is unnecessary as of alphagov/govuk-jenkinslib#82
ChrisBAshton
added a commit
to alphagov/calculators
that referenced
this pull request
Jan 18, 2021
The sassLint option was removed in alphagov/govuk-jenkinslib#80 And the Yarn install step is unnecessary as of alphagov/govuk-jenkinslib#82
ChrisBAshton
added a commit
to alphagov/maslow
that referenced
this pull request
Jan 18, 2021
The sassLint option was removed in alphagov/govuk-jenkinslib#80 And the Yarn install step is unnecessary as of alphagov/govuk-jenkinslib#82
ChrisBAshton
added a commit
to alphagov/static
that referenced
this pull request
Jan 18, 2021
The sassLint option was removed in alphagov/govuk-jenkinslib#80 And the Yarn install step is unnecessary as of alphagov/govuk-jenkinslib#82
ChrisBAshton
added a commit
to alphagov/release
that referenced
this pull request
Jan 18, 2021
The sassLint option was removed in alphagov/govuk-jenkinslib#80 And the Yarn install step is unnecessary as of alphagov/govuk-jenkinslib#82
ChrisBAshton
added a commit
to alphagov/whitehall
that referenced
this pull request
Jan 18, 2021
The sassLint option was removed in alphagov/govuk-jenkinslib#80 And the Yarn install step is unnecessary as of alphagov/govuk-jenkinslib#82
ChrisBAshton
added a commit
to alphagov/travel-advice-publisher
that referenced
this pull request
Jan 18, 2021
The sassLint option was removed in alphagov/govuk-jenkinslib#80 And the Yarn install step is unnecessary as of alphagov/govuk-jenkinslib#82
ChrisBAshton
added a commit
to alphagov/contacts-admin
that referenced
this pull request
Jan 18, 2021
The sassLint option was removed in alphagov/govuk-jenkinslib#80 And the Yarn install step is unnecessary as of alphagov/govuk-jenkinslib#82
ChrisBAshton
added a commit
to alphagov/manuals-publisher
that referenced
this pull request
Jan 18, 2021
The sassLint option was removed in alphagov/govuk-jenkinslib#80 And the Yarn install step is unnecessary as of alphagov/govuk-jenkinslib#82
ChrisBAshton
added a commit
to alphagov/govuk-search-relevance-tool
that referenced
this pull request
Jan 18, 2021
The sassLint option was removed in alphagov/govuk-jenkinslib#80 And the Yarn install step is unnecessary as of alphagov/govuk-jenkinslib#82 The `yarn run lint` step should still [run after yarn dependencies have been installed](https://github.com/alphagov/govuk-jenkinslib/pull/82/files#diff-6f9c4dd7a8fcf2fc03dc9947f9c2253a3d3d640daf5d986943e4f1d1dfca306bR191).
ChrisBAshton
added a commit
to alphagov/govuk-search-relevance-tool
that referenced
this pull request
Jan 18, 2021
The sassLint option was removed in alphagov/govuk-jenkinslib#80 And the Yarn install step is unnecessary as of alphagov/govuk-jenkinslib#82 The `yarn run lint` step should still [run after yarn dependencies have been installed](https://github.com/alphagov/govuk-jenkinslib/pull/82/files#diff-6f9c4dd7a8fcf2fc03dc9947f9c2253a3d3d640daf5d986943e4f1d1dfca306bR191). And the rubyLintDiff option was removed in alphagov/govuk-jenkinslib#57.
ChrisBAshton
added a commit
to alphagov/govuk-search-relevance-tool
that referenced
this pull request
Jan 18, 2021
The sassLint option was removed in alphagov/govuk-jenkinslib#80 And the Yarn install step is unnecessary as of alphagov/govuk-jenkinslib#82 The `yarn run lint` step should still [run after yarn dependencies have been installed](https://github.com/alphagov/govuk-jenkinslib/pull/82/files#diff-6f9c4dd7a8fcf2fc03dc9947f9c2253a3d3d640daf5d986943e4f1d1dfca306bR191). And the rubyLintDiff option was removed in alphagov/govuk-jenkinslib#57.
kevindew
added a commit
to alphagov/content-publisher
that referenced
this pull request
Jan 20, 2021
This is no longer necessary following: alphagov/govuk-jenkinslib#82
thomasleese
pushed a commit
to alphagov/calculators
that referenced
this pull request
Jan 26, 2021
The sassLint option was removed in alphagov/govuk-jenkinslib#80 And the Yarn install step is unnecessary as of alphagov/govuk-jenkinslib#82
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello: https://trello.com/c/MeG1zc2m/195-roll-out-stylelint-config-gds-across-govuk
It's common for GOV.UK Rails apps to have yarn dependencies, currently
many any apps have a hook of:
beforeTest: { sh("yarn install") },. Thechanges in this commit will mean this can be removed.