Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure 'after' tests are not ignored #720

Merged
merged 2 commits into from
May 29, 2018
Merged

Ensure 'after' tests are not ignored #720

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0a608ed
Ensure 'after' tests are not ignored
NickColley May 24, 2018
6000f5c
Add CHANGELOG entry
NickColley May 29, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,9 @@ Internal:
- Fix CI timeouts: run Jest single thread in TravisCI
([PR #712](https://github.com/alphagov/govuk-frontend/pull/712))

- Ensure 'after' tests are not ignored
([PR #720](https://github.com/alphagov/govuk-frontend/pull/720))

## 0.0.29-alpha (Breaking release)

Breaking changes:
Expand Down
6 changes: 1 addition & 5 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
"release": "node bin/check-nvmrc.js && ./bin/release.sh",
"build:package": "node bin/check-nvmrc.js && gulp build:package --destination 'package' && npm run test:build:package",
"build:dist": "node bin/check-nvmrc.js && gulp build:dist --destination 'dist' && npm run test:build:dist",
"test": "standard && gulp test && gulp copy-assets && jest",
"test": "standard && gulp test && gulp copy-assets && jest --testPathIgnorePatterns='after-*'",
"test:build:package": "jest tasks/gulp/__tests__/after-build-package.test.js",
"test:build:dist": "jest tasks/gulp/__tests__/after-build-dist.test.js"
},
Expand Down Expand Up @@ -85,10 +85,6 @@
]
},
"jest": {
"testPathIgnorePatterns": [
"/node_modules/",
"after-*"
],
"setupTestFrameworkScriptFile": "./config/jest-setup.js",
"snapshotSerializers": [
"jest-serializer-html"
Expand Down