Ensure 'after' tests are not ignored #720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-720
|
changelog 🔏 |
alex-ju
approved these changes
May 29, 2018
There was a problem hiding this comment.
We either do it this way, or we can move the "after-*" to be ignored only for the main "test" task.
"test": "standard && gulp test && gulp copy-assets && jest --testPathIgnorePatterns='after-*'",
"test:build:package": "jest tasks/gulp/__tests__/after-build-package.test.js",
"test:build:dist": "jest tasks/gulp/__tests__/after-build-dist.test.js"
...
"testPathIgnorePatterns": [
"/node_modules/"
],
I'm fine with either option.
NickColley
force-pushed
the
fix-after-tests
branch
from
b10ae00
to
0a608ed
Compare
After tests are only used to test the result of other tasks, for example building the `dist/` folder.
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-720
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unblocks releases,
aftertests are only used to test the result of other tasks, for examplebuilding the
dist/folder.