Remove unused colour definitions #525
Merged
Commits on Feb 15, 2018
-
Remove unused colour definitions
None of these defined ‘applied’ colours are actually being used anywhere, so let’s remove them. The panel colour was used by the previous / next component which has been temporarily removed, but it would probably make more sense for that component to reference $govuk-grey-4 directly anyway.
-
Restructure ‘applied’ colour settings file
Better structure and document the applied colour settings file to make it clearer what each thing does.
-
Rename govuk-button-colour-darken-15
Rename govuk-button-colour-darken-15 to govuk-button-shadow-colour to better communicate how it is used, and decouple the name from the value. Currently to change the button shadow colour we would also have to change the name of the variable.
-
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.