Remove unused colour definitions #525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-525
NickColley
approved these changes
Feb 13, 2018
36degrees
added a commit
to alphagov/govuk-design-system
that referenced
this pull request
Feb 15, 2018
These colours are not actually used in Frontend and their definitions are being removed in the next version. As the only colour left in this section is in fact a border, not a background, rename the section. alphagov/govuk-frontend#525
36degrees
changed the title
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-525
|
@NickColley happy with the changelog entry? |
None of these defined ‘applied’ colours are actually being used anywhere, so let’s remove them. The panel colour was used by the previous / next component which has been temporarily removed, but it would probably make more sense for that component to reference $govuk-grey-4 directly anyway.
Better structure and document the applied colour settings file to make it clearer what each thing does.
Rename govuk-button-colour-darken-15 to govuk-button-shadow-colour to better communicate how it is used, and decouple the name from the value. Currently to change the button shadow colour we would also have to change the name of the variable.
36degrees
force-pushed
the
remove-unused-colour-definitions
branch
from
37765a3
to
3415f1c
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a load of applied colour definitions that are unused within Frontend.
There's a few things to consider here:
$govuk-panel-colour$govuk-highlight-colour$govuk-page-colourThis has been done in a few commits so that you can clearly see which variables are being removed amidst the re-structure.
Thoughts?