Remove redundant display style from govuk-header__menu-button
#3596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
querkmachine
changed the title
display style from .govuk-header__menu-button.govuk-header__menu-button
This display style was maintained to avoid a breaking change in v4.3.0. It can now be removed as part of the next breaking release.
querkmachine
force-pushed
the
remove-legacy-nav-toggle-css
branch
from
262bbaa to
40b74d1
Compare
owenatgov
approved these changes
May 9, 2023
romaricpascal
pushed a commit
that referenced
this pull request
May 18, 2023
Remove redundant display style from `.govuk-header__menu-button`
romaricpascal
changed the title
.govuk-header__menu-buttongovuk-header__menu-button
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A nice, tiny change!
This display style was maintained to avoid a breaking change in v4.3.0, where we changed from using CSS to using the
hiddenHTML attribute to hide the button.This should now be unnecessary, assuming users have followed the upgrade guidance.
Resolves #2746.