Skip to content

Commit

Permalink
Merge pull request #3596 from alphagov/remove-legacy-nav-toggle-css
Browse files Browse the repository at this point in the history
Remove redundant display style from `.govuk-header__menu-button`
  • Loading branch information
querkmachine authored May 9, 2023
2 parents fb90605 + 40b74d1 commit 1865177
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 1 deletion.
10 changes: 10 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,16 @@ Instead we recommend checking for the disabled attribute using [`$button.hasAttr

This change was introduced in [pull request #2830: Set the boolean disabled attribute consistently in the button component](https://github.com/alphagov/govuk-frontend/pull/2830).

#### Check that the mobile menu button in the header component works as expected

We've removed some styles from the `.govuk-header__menu-button` class. These styles were included on the mobile menu button to avoid introducing a breaking change in [GOV.UK Frontend v4.3.0](https://github.com/alphagov/govuk-frontend/releases/tag/v4.3.0).

If you're not using Nunjucks macros, and haven't done so already, add the `hidden` attribute to the button's HTML to ensure it continues working as expected. You do not need to make any changes if using the Nunjucks macro.

When working correctly, the button should only be shown on narrow screens when JavaScript is available. It should be hidden on wider screens or if JavaScript is unavailable.

This change was introduced in [pull request #3596: Remove redundant display style from `.govuk-header__menu-button`](https://github.com/alphagov/govuk-frontend/pull/3596).

#### Remove Internet Explorer 8 stylesheets, settings and mixins

We no longer support Internet Explorer 8 (IE8) in GOV.UK Frontend and no longer provide dedicated stylesheets for the browser. Remove any references to these stylesheets from your HTML.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,6 @@

.govuk-header__menu-button {
@include govuk-font($size: 16);
display: none;
position: absolute;
top: govuk-spacing(4);
right: 0;
Expand Down

0 comments on commit 1865177

Please sign in to comment.