Remove IE8-10 JavaScript polyfills, helpers, config #3570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colinrotherham
force-pushed
the
remove-ie8-js
branch
from
a955136
to
99c28cf
Compare
colinrotherham
changed the title
colinrotherham
force-pushed
the
remove-ie8-js
branch
from
99c28cf
to
f63b6b8
Compare
colinrotherham
force-pushed
the
remove-ie8-js
branch
from
f63b6b8
to
227b9aa
Compare
querkmachine
reviewed
May 3, 2023
querkmachine
reviewed
May 3, 2023
Comment on lines
-11
to
-30
| /** | ||
| * TODO: Ideally this would be a NodeList.prototype.forEach polyfill | ||
| * This seems to fail in IE8, requires more investigation. | ||
| * See: https://github.com/imagitama/nodelist-foreach-polyfill | ||
| * | ||
| * @deprecated Will be made private in v5.0 | ||
| * @template {Node} ElementType | ||
| * @param {NodeListOf<ElementType>} nodes - NodeList from querySelectorAll() | ||
| * @param {(value: ElementType, index: number, nodes: NodeListOf<ElementType>) => void} callback - Callback function to run for each node | ||
| * @returns {void} | ||
| */ | ||
| export function nodeListForEach (nodes, callback) { | ||
| if (window.NodeList.prototype.forEach) { | ||
| return nodes.forEach(callback) | ||
| } | ||
| for (var i = 0; i < nodes.length; i++) { | ||
| callback.call(window, nodes[i], i, nodes) | ||
| } | ||
| } | ||
|
|
querkmachine
reviewed
May 3, 2023
packages/govuk-frontend/src/govuk/components/error-summary/error-summary.mjs
Show resolved
Hide resolved
colinrotherham
changed the title
colinrotherham
force-pushed
the
remove-ie8-js
branch
from
227b9aa
to
90e040a
Compare
colinrotherham
force-pushed
the
remove-ie8-js
branch
from
90e040a
to
0a96bad
Compare
|
@querkmachine I've rebased on top of #3559 to avoid Review app conditional comment conflicts etc Think we're looking good? |
colinrotherham
commented
May 3, 2023
| @@ -41,7 +41,7 @@ module.exports = { | |||
| extends: [ | |||
| 'plugin:@typescript-eslint/recommended', | |||
| 'plugin:@typescript-eslint/recommended-requiring-type-checking', | |||
| 'plugin:es-x/restrict-to-es3' | |||
| 'plugin:es-x/restrict-to-es5' | |||
There was a problem hiding this comment.
We can raise this even higher once IE11 is prevented from loading JS
https://eslint-community.github.io/eslint-plugin-es-x/#presets
querkmachine
approved these changes
May 3, 2023
colinrotherham
force-pushed
the
review-app-user
branch
from
8586ba4
to
1593117
Compare
colinrotherham
force-pushed
the
remove-ie8-css
branch
from
d736de5
to
6202660
Compare
colinrotherham
force-pushed
the
remove-ie8-js
branch
from
0a96bad
to
f7948c3
Compare
colinrotherham
force-pushed
the
remove-ie8-css
branch
from
6202660
to
78f4120
Compare
colinrotherham
force-pushed
the
remove-ie8-js
branch
from
f7948c3
to
d2ca164
Compare
colinrotherham
force-pushed
the
remove-ie8-css
branch
from
78f4120
to
9862a1e
Compare
Swaps the `addEventListener()` (IE8 only) example for `closest()`
colinrotherham
force-pushed
the
remove-ie8-js
branch
from
d2ca164
to
1df7e0e
Compare
2 tasks
romaricpascal
pushed a commit
that referenced
this pull request
May 18, 2023
Remove IE8-10 JavaScript polyfills, helpers, config
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR unblocks #3279 by removing Rollup
{ legacy: true }so we can pick up:Similar to #3559 this PR also tackles IE8-10 JavaScript things:
nodeListForEachhelper function #3466