Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Rollup #3462

Closed
1 task
Tracked by #2621
, #3505 ,  #3279 ,  #3504
...
romaricpascal opened this issue Mar 31, 2023 · 2 comments
Closed
1 task
Tracked by #2621
, #3505 ,  #3279 ,  #3504
...

Upgrade Rollup #3462

romaricpascal opened this issue Mar 31, 2023 · 2 comments
Labels
javascript tooling
Milestone
v5.0

Comments

@romaricpascal
Copy link
Member

romaricpascal commented Mar 31, 2023 •
edited by 36degrees
Loading

What

Upgrade Rollup and any other related dependencies to the latest version(s).

Why

We previously pinned Rollup to maintain support for IE8. As we're dropping support for IE8, we can unpin the dependency and use the latest version.

Who needs to work on this

Developers

Who needs to review this

Developers

Done when

  • Rollup has been upgraded to its latest version
@romaricpascal romaricpascal mentioned this issue Mar 31, 2023
Closed
@36degrees
Copy link
Contributor

We should go back and simplify the compileJavaScript function in tasks/scripts.mjs as part of this work – see #3386 (comment) for details

This was referenced Apr 14, 2023
Closed
Open
@36degrees 36degrees modified the milestone: v5.x-candidate Apr 25, 2023
@romaricpascal romaricpascal added this to the v5.0 milestone Apr 25, 2023
@romaricpascal romaricpascal mentioned this issue Apr 25, 2023
Open
3 tasks
@romaricpascal romaricpascal moved this from Backlog 🗄 to Sprint Backlog 🏃🏼‍♀️ in GOV.UK Design System cycle board Apr 25, 2023
@colinrotherham colinrotherham mentioned this issue May 2, 2023
Merged
@colinrotherham
Copy link
Contributor

Successfully closed by Dependabot (with a little helping hand)

We should go back and simplify the compileJavaScript function in tasks/scripts.mjs as part of this work – see #3386 (comment) for details

☝️ Regarding this bit above we sadly couldn't use { preserveModules } whilst we still build UMD bundles, presumably due to the way it uses a factory function to add window globals etc

It'll become dead code once we ship ESM-only (or alongside CommonJS for compatibility) so can be removed later

@colinrotherham colinrotherham mentioned this issue May 11, 2023
Merged
@colinrotherham colinrotherham moved this from Sprint Backlog 🏃🏼‍♀️ to Ready to release 🚀 in GOV.UK Design System cycle board May 12, 2023
@36degrees 36degrees moved this from Ready to release 🚀 to Done 🏁 in GOV.UK Design System cycle board Jul 6, 2023
@colinrotherham colinrotherham moved this from Done 🏁 to Ready to release 🚀 in GOV.UK Design System cycle board Jul 18, 2023
@36degrees 36degrees moved this from Ready to release 🚀 to Done 🏁 in GOV.UK Design System cycle board Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
javascript tooling
Projects
GOV.UK Design System cycle board
Archived in project
Milestone
v5.0
Development

No branches or pull requests
3 participants
@36degrees @romaricpascal @colinrotherham