Tweak whitespace HTML for text input component to improve readability #2475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2475
vanitabarrett
changed the title
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2475
36degrees
approved these changes
Dec 21, 2021
There was a problem hiding this comment.
I think this makes sense – just a minor issue re heading levels in the changelog.
We should keep an eye out for feedback from those using our fixtures – hopefully most will be testing in a way that's forgiving of whitespace changes, but otherwise this sort of 'tweaking' might create extra work for them.
vanitabarrett
force-pushed
the
whitespace-input
branch
from
ac7397f
to
333c976
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2475
added 2 commits
December 22, 2021 09:29
Tweak the input component nunjucks macro slightly to improve the whitespace of the output HTML so that: - the closing `div` for the form group is on a new line (fixes alphagov/govuk-design-system#1939) - there is no unecessary whitespace between the `govuk-input__wrapper` and `govuk-input__prefix` or `govuk-input__suffix`
vanitabarrett
force-pushed
the
whitespace-input
branch
from
333c976
to
a725c56
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2475
EoinShaughnessy
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tweak the input component nunjucks macro slightly to improve the whitespace of the output HTML so that:
divfor the form group is on a new line(closing div is not on a new line in fieldset html example govuk-design-system#1939)
govuk-input__wrapperand
govuk-input__prefixBefore vs After (default input example)
Before:
After:
Before vs After (input with prefix and suffix)
Before:
After:
