Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

closing div is not on a new line in fieldset html example #1939

Closed
joelanman opened this issue Oct 7, 2021 · 1 comment
Closed

closing div is not on a new line in fieldset html example #1939

joelanman opened this issue Oct 7, 2021 · 1 comment
Labels
🐛 bug Something isn't working the way it should (including incorrect wording in documentation)
Milestone
v4.0.1

Comments

@joelanman
Copy link
Contributor

On the html example for Fieldset, the closing div for govuk-form-group is not on a new line, this makes it a little harder to see where govuk-form-group ends

https://design-system.service.gov.uk/components/fieldset/

<div class="govuk-form-group">
    <label class="govuk-label" for="address-line-1">
      Building and street <span class="govuk-visually-hidden">line 1 of 2</span>
    </label>
    <input class="govuk-input" id="address-line-1" name="address-line-1" type="text" autocomplete="address-line1"></div>
@joelanman joelanman added 🐛 bug Something isn't working the way it should (including incorrect wording in documentation) awaiting triage Needs triaging by team labels Oct 7, 2021
vanitabarrett pushed a commit to alphagov/govuk-frontend that referenced this issue Dec 14, 2021
Tweak whitespace for input component HTML
3665be0 
Tweak the input component nunjucks macro slightly to improve
the whitespace of the output HTML so that:

- the closing `div` for the form group is on a new line
(fixes alphagov/govuk-design-system#1939)
- there is no unecessary whitespace between the `govuk-input__wrapper`
and `govuk-input__prefix`
vanitabarrett pushed a commit to alphagov/govuk-frontend that referenced this issue Dec 14, 2021
Tweak whitespace for input component HTML
2f4dad1 
Tweak the input component nunjucks macro slightly to improve
the whitespace of the output HTML so that:

- the closing `div` for the form group is on a new line
(fixes alphagov/govuk-design-system#1939)
- there is no unecessary whitespace between the `govuk-input__wrapper`
and `govuk-input__prefix` or `govuk-input__suffix`
@vanitabarrett vanitabarrett mentioned this issue Dec 14, 2021
Merged
@vanitabarrett vanitabarrett reopened this Dec 22, 2021
@vanitabarrett
Copy link
Contributor

This issue will be fixed by alphagov/govuk-frontend#2475 which has been merged into govuk-frontend and will be released in the next version.

@vanitabarrett vanitabarrett added this to the [NEXT] milestone Dec 22, 2021
@vanitabarrett vanitabarrett removed the awaiting triage Needs triaging by team label Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 bug Something isn't working the way it should (including incorrect wording in documentation)
Projects
GOV.UK Design System cycle board
Archived in project
Milestone
v4.0.1
Development

No branches or pull requests
2 participants
@joelanman @vanitabarrett