Add data-nosnippet to prevent cookie banner text appearing in Google Search snippets
#2192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
36degrees
reviewed
Apr 16, 2021
There was a problem hiding this comment.
I think this makes sense, but as I sort of prompted this PR I think it'd be worth @hannalaakso reviewing in case she can think of any reason why this would ever be problematic.
For users that don't know what data-nosnippet does, is there a better description for the changelog / PR title that focuses on the outcome of the change?
I also wonder if it'd also be useful to cross-reference the PR from GOV.UK where they added this in the commit message? Just as 'prior art'.
Great spot adding the missing README as well.
vanitabarrett
changed the title
vanitabarrett
force-pushed
the
cookie-banner-tweaks
branch
from
f8ab8c4
to
4ff5ae3
Compare
added 3 commits
April 19, 2021 15:36
The data-nosnippet attribute stops the cookie banner text from appearing in any Google Search text snippets.
vanitabarrett
force-pushed
the
cookie-banner-tweaks
branch
from
4ff5ae3
to
c4ef8b5
Compare
2 tasks
hannalaakso
approved these changes
Apr 19, 2021
Merged
EoinShaughnessy
changed the title
data-nosnippet to prevent cookie banner text appearing in Google Search snippets
hannalaakso
added a commit
that referenced
this pull request
Oct 27, 2021
The data-nosnippet attribute stops the 'show' text from appearing in any Google Search text snippets. We have successfully used a similar approach for the [cookie banner](#2192) and on [GOV.UK Publishing components](alphagov/govuk_publishing_components#1185)
hannalaakso
added a commit
that referenced
this pull request
Oct 27, 2021
The data-nosnippet attribute stops the 'show' text from appearing in any Google Search text snippets. We have successfully used a similar approach for the [cookie banner](#2192) and on [GOV.UK Publishing components](alphagov/govuk_publishing_components#1185)
hannalaakso
added a commit
that referenced
this pull request
Oct 28, 2021
The data-nosnippet attribute stops the 'show' text from appearing in any Google Search text snippets. We have successfully used a similar approach for the [cookie banner](#2192) and on [GOV.UK Publishing components](alphagov/govuk_publishing_components#1185)
hannalaakso
added a commit
that referenced
this pull request
Nov 1, 2021
The data-nosnippet attribute stops the 'show' text from appearing in any Google Search text snippets. We have successfully used a similar approach for the [cookie banner](#2192) and on [GOV.UK Publishing components](alphagov/govuk_publishing_components#1185)
Merged
peteryates
added a commit
to x-govuk/govuk-components
that referenced
this pull request
Dec 21, 2021
Apply a data-nosnippet attribute to the cookie banner component to stop it appearing in Google Search snippets. alphagov/govuk-frontend#2192
frankieroberto
added a commit
to DFE-Digital/find-teacher-training
that referenced
this pull request
Jan 10, 2022
andymantell
added a commit
to surevine/govuk-react-jsx
that referenced
this pull request
Jan 29, 2022
tombye
added a commit
to alphagov/notifications-admin
that referenced
this pull request
Nov 22, 2022
Implemented on the GOVUK Frontend cookie banner component in: alphagov/govuk-frontend#2192 This tells Google to ignore the cookie banner when it indexes the content of our pages.
tombye
added a commit
to alphagov/notifications-admin
that referenced
this pull request
Nov 23, 2022
Implemented on the GOVUK Frontend cookie banner component in: alphagov/govuk-frontend#2192 This tells Google to ignore the cookie banner when it indexes the content of our pages.
tombye
added a commit
to alphagov/notifications-admin
that referenced
this pull request
Nov 24, 2022
Implemented on the GOVUK Frontend cookie banner component in: alphagov/govuk-frontend#2192 This tells Google to ignore the cookie banner when it indexes the content of our pages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add
data-nosnippetto the cookie banner componentWhy
Taken inspiration from alphagov/govuk_publishing_components#1185
Apply a
data-nosnippetattribute to the cookie banner component to stop its text content appearing in Google Search snippets.We think we can make this change without adding a macro option to remove the attribute, as we can't think of a scenario where you would want the cookie banner text to appear in Google Search snippets.