Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider documenting data-nosnippet addition to cookie banner component #2196

Closed
2 tasks done
vanitabarrett opened this issue Apr 19, 2021 · 1 comment
Closed
2 tasks done

Consider documenting data-nosnippet addition to cookie banner component #2196

vanitabarrett opened this issue Apr 19, 2021 · 1 comment
Labels
cookie banner documentation User requests new documentation or improvements to existing documentation

Comments

@vanitabarrett
Copy link
Contributor

vanitabarrett commented Apr 19, 2021 •
edited by 36degrees
Loading

What

Consider documenting the data-nosnippet attribute. It's not a breaking change, it's an improvement to the existing HTML, but people using the HTML for the cookie banner component will need to add this attribute manually.

Why

In #2192 we added the data-nosnippet attribute to the cookie banner component.

Who needs to know about this

Developers, Technical Writer, Content Designer

Done when

  • Decided whether to document this change
  • Drafted content
@vanitabarrett vanitabarrett added documentation User requests new documentation or improvements to existing documentation cookie banner labels Apr 19, 2021
@vanitabarrett vanitabarrett added this to the v4.0.0 milestone Apr 19, 2021
@vanitabarrett vanitabarrett removed this from the v4.0.0 milestone Aug 24, 2021
@vanitabarrett vanitabarrett mentioned this issue Sep 8, 2021
Closed
4 tasks
@EoinShaughnessy EoinShaughnessy changed the title Consider documenting data-nosnippet addition to cookie banner component Consider documenting data-nosnippet addition to cookie banner component Sep 27, 2021
@36degrees
Copy link
Contributor

This was included as a recommended change in the release notes for v4.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cookie banner documentation User requests new documentation or improvements to existing documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@36degrees @vanitabarrett