Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stray line on checkbox in IE11 #134

Merged
merged 1 commit into from
Jul 17, 2017
Merged

Conversation

gemmaleigh
Copy link
Contributor

IE sometimes miscalculates the border width of a rotated element
resulting in a thin border as shown in #518.

Setting a transparent border fixes this.

Before:
28029483-1f1a21fa-6598-11e7-8821-3d63dc822fe0

After:
28029400-de1357a8-6597-11e7-87b9-dfbf8565c79e

See govuk-elements #520.

IE sometimes miscalculates the border width of a rotated element
resulting in a thin border as shown in #518.

Setting a transparent border fixes this.
@gemmaleigh gemmaleigh requested a deployment to govuk-frontend-review-pr-134 July 14, 2017 17:44 Pending
@gemmaleigh gemmaleigh requested a deployment to govuk-frontend-review-pr-134 July 14, 2017 17:45 Pending
@gemmaleigh gemmaleigh merged commit 596dfc4 into master Jul 17, 2017
@gemmaleigh gemmaleigh deleted the fix-checkbox-tick-ie11 branch July 17, 2017 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants