Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: add a 'positive' colour #518

Closed
kr8n3r opened this issue Feb 9, 2018 · 4 comments
Closed

Proposal: add a 'positive' colour #518

kr8n3r opened this issue Feb 9, 2018 · 4 comments

Comments

@kr8n3r
Copy link

kr8n3r commented Feb 9, 2018

Copied over from GOV.UK Frontend toolkit

There are cases where it's useful to have a colour with a semantic meaning of 'positive'.

We already have error_colour which is a good red for 'negative' - but we don't have a counterpart.

We could use an existing colour, or make a new colour. Either way, a semantic SASS name would be good.

The closest colour would be button_colour. An alternate would be #008800 which is the green used by petitions. It's warmer, which feels more positive to me.

image

@fofr
Copy link
Contributor

fofr commented Feb 9, 2018

In https://whitehall-prototype.herokuapp.com/patterns/flash-notices we are using the button colour.

screen shot 2018-02-09 at 13 57 19

@edwardhorsford
Copy link
Contributor

I might also suggest we possibly make a 'negative' colour that references error-colour. Semantic names FTW.

Use cases

We used positive / negative on the first version of the Performance Platform.

Certain other services which include tables / graphs may also benefit. I'm thinking things like flood warnings / travel advice.

@dashouse
Copy link

Be aware, Mark Hurell has some broader colour changes coming up. I would not suggest adding any other colours to the palette.

@kr8n3r
Copy link
Author

kr8n3r commented Jun 28, 2018

closing, will await colour changes

@kr8n3r kr8n3r closed this as completed Jun 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants