Add Discovery Engine configuration to search-admin
#762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are about to start some work that hooks Search Admin up to Discovery Engine (aka Google Vertex AI Search), so we need to: - Mount the `gcloud` tool config directory into the container (which allows the Google Cloud gem(s) to pick up on locally configured credentials) - Set appropriate environment variables for the engine and serving config that the app should use locally (`integration` as we no longer have a separate dev environment) These changes are analogous to the ones made in #695 and #712 for `search-api-v2`.
deborahchua
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are about to start some work that hooks Search Admin up to Discovery Engine (aka Google Vertex AI Search), so we need to:
gcloudtool config directory into the container (which allows the Google Cloud gem(s) to pick up on locally configured credentials)integrationas we no longer have a separate dev environment)These changes are analogous to the ones made in #695 and #712 for
search-api-v2.