Hardcode discovery engine environment variables in search-api-v2 #712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csutter
approved these changes
Jan 5, 2024
| # e.g. "projects/search-api-v2-dev/locations/global/collections/default_collection/dataStores/ | ||
| # local-my-name/servingConfigs/default_serving_config" | ||
| DISCOVERY_ENGINE_SERVING_CONFIG: "${DISCOVERY_ENGINE_SERVING_CONFIG}" | ||
| DISCOVERY_ENGINE_DATASTORE_BRANCH: "projects/780375417592/locations/global/collections/default_collection/dataStores/govuk_content/branches/default_branch" |
There was a problem hiding this comment.
Come to think of it, it'll look more readable if we use the "pretty" GCP project name (search-api-v2-integration) instead of the numeric one for both of these 🎁
There was a problem hiding this comment.
So we can use "projects/search-api-v2-integration/locations/global/collections/default_collection/dataStores/govuk_content/branches/default_branch"?
There was a problem hiding this comment.
@csutter I've updated to use the pretty name.
We've decided it's easier for the local setup of search-api-v2 to pull in search results from integration whenever search results are needed for local testing rather than making everyone set up their own personal discovery engine on gcloud. Therefore the env var values can be hardcoded rather than being set in the local session.
leenagupte
force-pushed
the
add-search-api-v2-env-vars
branch
from
f1c8917 to
9f46ef2
Compare
csutter
added a commit
that referenced
this pull request
Jul 4, 2024
We are about to start some work that hooks Search Admin up to Discovery Engine (aka Google Vertex AI Search), so we need to: - Mount the `gcloud` tool config directory into the container (which allows the Google Cloud gem(s) to pick up on locally configured credentials) - Set appropriate environment variables for the engine and serving config that the app should use locally (`integration` as we no longer have a separate dev environment) These changes are analogous to the ones made in #695 and #712 for `search-api-v2`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've decided it's easier for the local setup of search-api-v2 to pull in search results from integration whenever search results are needed for local testing rather than making everyone set up their own personal discovery engine on gcloud. Therefore the env var values can be hardcoded rather than being set in the local session.