-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explain that red border depends on exceeding limit #2188
Conversation
✅ You can preview this change here:
To edit notification comments on pull requests, go to your Netlify site settings. |
This is how I originally reworded it:
|
Thanks all! Minor suggestion otherwise looks good, we'll need to check how to release this alongside #2181? |
5a09b3d
to
f60bdc7
Compare
@calvin-lau-sig7 My bad! Sorry, should have double checked. If it helps, feel free to take the content out of this PR and add it to the bigger update. |
f60bdc7
to
316bc7f
Compare
@calvin-lau-sig7 The major character count update is now live 🎉 so I've tried rebasing this PR, and hopefully this little update is now also good to go... |
Fixes #2140.
The character count input only shows a red border when the character limit is exceeded. If there's been some other error, and the content is within the limit, it doesn't show this border.
Some users have reported being confused by this, so we're adding guidance to explain why.