Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain that red border depends on exceeding limit #2188

Merged
merged 1 commit into from
May 18, 2022

Conversation

EoinShaughnessy
Copy link
Contributor

Fixes #2140.

The character count input only shows a red border when the character limit is exceeded. If there's been some other error, and the content is within the limit, it doesn't show this border.

Some users have reported being confused by this, so we're adding guidance to explain why.

@netlify
Copy link

netlify bot commented May 17, 2022

You can preview this change here:

Name Link
🔨 Latest commit 316bc7f
🔍 Latest deploy log https://app.netlify.com/sites/govuk-design-system-preview/deploys/6284e9cba54a1000095c2555
😎 Deploy Preview https://deploy-preview-2188--govuk-design-system-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@EoinShaughnessy
Copy link
Contributor Author

This is how I originally reworded it:

The input shows a red border only when the user tries sending too many characters. It does not show this border when there's been an error, but the number of characters is within the limit. We felt it might cause the user difficulty if the border disappeared once they started typing into the input.

@calvin-lau-sig7
Copy link
Contributor

Thanks all! Minor suggestion otherwise looks good, we'll need to check how to release this alongside #2181?

@EoinShaughnessy
Copy link
Contributor Author

@calvin-lau-sig7 My bad! Sorry, should have double checked. If it helps, feel free to take the content out of this PR and add it to the bigger update.

@EoinShaughnessy EoinShaughnessy force-pushed the update-char-count-about-red-border branch from f60bdc7 to 316bc7f Compare May 18, 2022 12:42
@EoinShaughnessy
Copy link
Contributor Author

@calvin-lau-sig7 The major character count update is now live 🎉 so I've tried rebasing this PR, and hopefully this little update is now also good to go...

@EoinShaughnessy EoinShaughnessy merged commit 022d59b into main May 18, 2022
@EoinShaughnessy EoinShaughnessy deleted the update-char-count-about-red-border branch May 18, 2022 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants