Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update character count guidance to match new implementation #2181

Merged
merged 4 commits into from
May 18, 2022
Merged

Update character count guidance to match new implementation #2181

merged 4 commits into from
May 18, 2022

Conversation

calvin-lau-sig7
Copy link
Contributor

@calvin-lau-sig7 calvin-lau-sig7 commented May 11, 2022 •
edited
Loading

Make content changes for issue #2155

@calvin-lau-sig7 calvin-lau-sig7 self-assigned this May 11, 2022
@calvin-lau-sig7 calvin-lau-sig7 linked an issue May 11, 2022 that may be closed by this pull request
Update character count guidance to match new implementation #2155
Closed
4 tasks
calvin-lau-sig7
calvin-lau-sig7 commented May 11, 2022
View reviewed changes
src/components/character-count/index.md.njk
@@ -107,9 +112,7 @@ During this research, the component was tested with 17 users, including those wi

### Known issues and gaps

This comment was marked as outdated.

Sign in to view

@netlify
Copy link

netlify bot commented May 11, 2022 •
edited
Loading

✅ You can preview this change here:

Name Link
🔨 Latest commit 58e99ff
🔍 Latest deploy log https://app.netlify.com/sites/govuk-design-system-preview/deploys/62836c656df6fd00082fca30
😎 Deploy Preview https://deploy-preview-2181--govuk-design-system-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@vanitabarrett vanitabarrett added this to the v4.1.0 milestone May 13, 2022
@vanitabarrett vanitabarrett mentioned this pull request May 13, 2022
Closed
4 tasks
dav-idc
dav-idc approved these changes May 16, 2022
View reviewed changes
Copy link
Contributor

@dav-idc dav-idc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good overall, and think it's good enough for the launch of the component update!

@calvin-lau-sig7 calvin-lau-sig7 force-pushed the calvin-lau-sig7-char-count-guidance branch from b6e4308 to 76fe69f Compare May 16, 2022 15:54
@calvin-lau-sig7 calvin-lau-sig7 force-pushed the calvin-lau-sig7-char-count-guidance branch from 8d00d2d to 6ff61ed Compare May 16, 2022 16:21
@calvin-lau-sig7 calvin-lau-sig7 mentioned this pull request May 18, 2022
Merged
@EoinShaughnessy EoinShaughnessy mentioned this pull request May 18, 2022
Closed
2 tasks
@domoscargin domoscargin merged commit f5a7be2 into main May 18, 2022
@domoscargin domoscargin deleted the calvin-lau-sig7-char-count-guidance branch May 18, 2022 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dav-idc dav-idc dav-idc approved these changes

@vanitabarrett vanitabarrett Awaiting requested review from vanitabarrett

Assignees

@calvin-lau-sig7 calvin-lau-sig7

Labels
guidance
Projects
None yet
Milestone
v4.1.0
Development

Successfully merging this pull request may close these issues.

Update character count guidance to match new implementation
4 participants
@calvin-lau-sig7 @dav-idc @domoscargin @vanitabarrett