-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Button #34
Comments
Related article: Disabled buttons suck |
Why are there two different methods used to render a button? The start button type used an |
Hi, thanks for getting in touch When used in a form then a |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
We are working on "Add a course" backend portal used by the Providers to add a new course. Think of Gmail inbox with each email being a course with a date, duration, cost etc. Any idea how these buttons would be (if anyone has done this and have an example that would be super helpful) implemented on one page as a GDS design pattern? |
I am following GDS and I have to create Secondary and Tertiary buttons for the site, but couldn't find these buttons styles in GDS, if anyone has done please share, it will be helpful. - Thanks |
I wonder if button should be wrapped in I've joined a service and our cancel links sit weirdly with buttons - I suspect in most situations (page per thing), you'll want the button to be a block level element - whereas right now it behaves as if it's inline. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@vickytnz it's a good point and potentially we can look at improving the design for colourblind people, but it's important to note colour isn't the only thing conveying meaning here - the button text does too. |
In principle the buttons could be the same colour. So it's not an absolute barrier for users. With that said, we make them different because we think one should be clearly the primary one - and we should try to continue that. The general luminance between both primary and secondary should be different - which it looks like it is. @vickytnz in the example above they don't look the same - the 'save and continue' looks much darker / different from the 'save as draft'. Can you explain what looks the same to you? |
@edwardhorsford I think Vicky's referring to Primary vs Destructive, not Secondary |
Does anyone have any recent accessibility research findings on the use the 'start now' links (buttons) with voice recognition software? (eg. Dragon). The start now button relies on the aria role 'button' to make use of the 'click button' voice command to show the user all the buttons on the page. Aria role isn't supported by versions of Dragon below v13, which, as pointed out in the blog post Results of the 2016 GOV.UK assistive technology survey, is not the most commonly used version of Dragon (well not in 2016, at least) |
In the accessibility lab at GDS we are running versions 13 and 15 on which the start buttons do work. I can’t recall now if they didn’t work with v 12 or 12.5. I would anticipate there wouldn’t be much usage now below version 13 and if the button doesn’t work directly with Dragon there is the option for the user of Mousegrid which should operate it without difficulty (although I always tell people that is a bit of a compromise) |
Thanks @accessiblewebuk for your response. Do we have any more recent data about assistive tech usage (and versions)? Does anyone know of any plans to conduct another assistive tech survey? |
From a Slack conversation - I think the wording proposed for the buttons is odd - do users really need to know information is saved at every step? surely that's assumed. It leads to some screen reader issues where different buttons for "save and continue" and "save and exit" sound alike. |
@antimega You might be right, but just to say that not all services do Save and continue - shorter transactions without accounts like Register to vote for example |
Most services I've seen don't use Save and continue. |
@antimega @joelanman If there are two buttons ('Save and continue' and 'Continue without saving') then the distinction might be important but I can't imagine that situation arising. If there's only one button then I can't see a significant benefit in describing whether it saves or doesn't. |
Hi Mark - could clicking on the download button act as the confirmation? I imagine the service would be able to tell if the user had done that, and then you wouldn't need the checkbox at all. |
Based on this comment in the backlog: alphagov/govuk-design-system-backlog#34 (comment)
The NHS found some problems in user research with buttons being full width in mobile view: nhsuk/nhsuk-service-manual-community-backlog#7
|
GOV.UK Design System working group review: Updated button styles componentRepresentatives from the GOV.UK Design System working group reviewed this contribution in December 2020. Based on a majority vote, the group decided that:
They also made the following recommendations. Guidance
Design
Code
Next stepsBased on this feedback, the GOV.UK Design System team have agreed to:
|
from an accessibility report, a comment on the grey secondary button:
|
Further to @joelanman 's comment. we have just done some user testing with a partially sighted user (blind in one eye). For most of the journey they seemed pretty confident but we noticed that they struggled with the grey secondary button in a few places. |
@adamliptrot-oc Before my time, but I speculate it's because on mobile we use full width buttons and it helps keep the button looking more 'balanced'. |
Following previous comments re: issues in recognising full width buttons on mobile as well as magnifier users, |
Thats an interesting one. I'm not sure buttons should be that long to go onto multiple lines. I think they should be short and to the point which may mitigate the need for this work. For example instead of I think if a button gets too long then it can become harder to understand what it will do. We spent a bit of time with content designers working on keeping our buttons short, providing an idea of what it will do/where the user will go. |
@titlescreen I completely agree, buttons should be short and to the point. It is part of their 'button' identity. |
Some questions around labels when save and return is an option, there seems to be some inconsistency. The design system has:
The GOV.UK Sign In service uses a ‘Continue’ button and ‘Save and complete later’ link in their documentation. |
Is there a reason why the hover states for buttons (and links) are so slight compared to the focus states? |
We had a low vision user on support today make note of the poor contrast on secondary buttons:
This is following them querying the contrast on the secondary button and me making a note of the bottom border as a visual delimiter. There have been a couple of mentions in this issue to the secondary button not being great for low vision users even with the bottom border. At present it technically doesn't fail 1.4.11 but it still might not be 100% accessible. |
It looks like the js which handles links which are styled as buttons (with the I've written up some testing: https://liptrot.org/posts/links_buttons_roles_and_behaviours/ |
Very good point @adamliptrot-oc We'd love a contribution if you'd like to open a pull request? |
What is the justification for setting I am asking this because we are discussing the removal of |
We've had lots of trouble with users submitting forms twice on govuk-design-system projects and found that the "preventDoubleClick" setting is insufficient, because the button turns back on again after 1 second. Users who are still waiting for the form to submit will then click the button again at that point. So we are not using the "preventDoubleClick" setting but instead have custom js code that permanently disables the form submit buttons after first click, regardless of how long the actual form submit takes. This has very much reduced the number of form double-submits we get, and we haven't had any user complaints about it. Why was the 1 second timeout chosen? Would you consider changing the "preventDoubleClick" setting from 1 sec to permanent? ... and, if it were up to me, this would be on by default, rather than opt-in. What service actually wants double form submissions? |
Use this issue to discuss the button component from the GOV.UK Design System.
The text was updated successfully, but these errors were encountered: