Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full-width buttons not documented, which means we use them inconsistently across services #449

Closed
mrmjprice opened this issue Oct 15, 2020 · 6 comments
Assignees
Labels
Awaiting go live ✅ This issue has been completed and is awaiting go live from the release branch feature_request released

Comments

@mrmjprice
Copy link
Contributor

mrmjprice commented Oct 15, 2020

What

We need to write documentation for when to use [ text width ] and [ full-width 1-col ] buttons
This is important so we can make consistent services

Why

Explain why you think this should be added to the West Midlands Network Design System (WMN DS).

  • It's not clear when to use full-width (we usually do this for continue buttons on a question page) or text width only, which we use for pretty much every other button

Anything else

NHS uses [text width], as they found users treat full-width buttons like they're headers
GOV.UK Design System uses [text width] for desktop and [full width] for mobile
Our current page about buttons

@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label feature_request to this issue, with a confidence of 0.54. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@mrmjprice
Copy link
Contributor Author

mrmjprice commented Oct 15, 2020

For what it's worth, I prefer GOV.UK's approach as it means users don't have to strain their thumb to click a button.

@mrmjprice
Copy link
Contributor Author

Also, an interesting experience of a team changing a start button from blue to green is documented in the GOV.UK Design System backlog. They found 9% higher click-through rate.

@jkmnch
Copy link
Contributor

jkmnch commented Oct 20, 2020

I agree with the GOV approach to text-width buttons on desktop and full-width buttons on mobile. Here is the documentation to be added under the 'About' section of the Buttons component page:

H3: Button size

  • The button width on desktop should be proportional with the text inside the button. Desktop buttons are aligned to the left edge of the content container.
  • Buttons are full-width on mobile. This is so users can easily tap on a button without stretching their thumb.
  • For the Question Form pattern, the ‘Continue’ call to action button should always be full-width within the container on desktop and mobile devices.

@catiarodriguescosta catiarodriguescosta added the Awaiting go live ✅ This issue has been completed and is awaiting go live from the release branch label Jan 15, 2021
@wmcadigital-admin
Copy link

🎉 This issue has been resolved in version 1.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@houbly
Copy link
Contributor

houbly commented Jan 21, 2021

This update is now live

@houbly houbly closed this as completed Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting go live ✅ This issue has been completed and is awaiting go live from the release branch feature_request released
Projects
None yet
Development

No branches or pull requests

6 participants